Hello Vagrant, Thanks for the followup. Comments below.
On Fri, Jan 05, 2024 at 01:33:00PM -0800, Vagrant Cascadian wrote: > On 2024-01-05, Vagrant Cascadian wrote: > > On 2023-11-23, Andreas Henriksson wrote: > >> On Thu, Nov 23, 2023 at 08:16:43PM +0100, Tobias Heider wrote: > >>> On Thu, Nov 23, 2023 at 10:51:04AM -0800, Vagrant Cascadian wrote: > >>> > On 2023-11-23, Andreas Henriksson wrote: > > ... > >>> > > 3/ do we include patches? > >>> > > 3.1/ No patches. If this is the desired path I can volunteer > >>> > > to test that it boots on my M1 machine. Other machines > >>> > > should probably be considered unsupported for now, > >>> > > even though they might have limited usefulness. > >>> > > 3.2/ Minimal set of patches. We identify what we consider > >>> > > crutial only patches and recruit volunteers to test. > >>> > > M2 keyboard? USB? etc... > >>> > > 3.3/ All asahi patches. We consider it simpler to just sync all > >>> > > patches > >>> > > with the asahi fork (even though some are even unused, like the > >>> > > devicetree patches). We trust the Asahi Linux project in their > >>> > > quest to upstream all their work and that they will rebase on > >>> > > newer > >>> > > releases and make our job easy. > >>> > > >>> > I am inclined towards starting with no patches or a minimal set of > >>> > patches. The asashi folks do seem to generally do a good job of > >>> > upstreaming, so support should improve over time. > >> > >> I'm not against going this route, my only concern is using the asahi > >> name while shipping an "inferior" variant (no patches). The Asahi Linux > >> people have been very good at being end-user focused, fixing all kind of > >> bugs and really go above and beyond to not compromise on end user > >> experience. Not sure they'd appreciate us shipping it under their name > >> while exposing "already fixed" bugs.... but what do I know. > >> We can always add patches later I guess. The Trixie freeze is not > >> happening soon and we're not providing any installer yet, so it should > >> just be a few #debian-bananas people trying this out for a while still > >> I guess. > > > > This seems like the main blocker at this point; I am hoping to upload at > > least 2024.01-rc6 to experimental shortly (and 2024.01 to unstable once > > it releases), and it would be nice to include a u-boot variant > > supporting these boards, but I am nervous about shipping patches. As > > you pointed out an unpatched version with asashi in the name might not > > be appreciated... but ... uh, er. Hrm. I would really like to get this > > in! > > I guess we could include a note in the description? Something like: > > This package does not include all patches shipped by the asahi project, > only patches that have been merged in mainline u-boot. I've been thinking the same thing about just putting info in the description (even if noone ever reads the long description :/). I think we should mention specific which issues to expect, fortunately many changes has already gone upstream for 2024.01 release so these are the high-level ones I can spot are still missing: - keyboard support on m2 models. - multi-os support (eg. multiple linux/bsd installs). - firmware loading (eg. on models with usb type-A ports). (Not sure how important the last one is to mention, could probably be left out.) Hopefully this is all resolved before Trixie freeze (and by then we might want to mention we only support M1/M2 and not M3 and whatever the Apple and Asahi Linux project has been up to in the meantime). FWIW. https://github.com/AsahiLinux/u-boot has already been rebased on latest denx/master (2024.01-rc) and the delta is now down to 20 commits. Devicetree updates is not relevant to us, ignoring those we also don't need the dtc changes - this would lower the number even more. The remaining commits are split up to nicely refactor things for implementing the three above mentioned features. Basically all now touching Apple-specific code/files (except adding a few function prototypes to header files, Kconfig/Makefile hookups and additions to xhci-pci-asmedia). I think we can go ahead with using the u-boot-asahi name and hope we can proceed as planned. > > > live well, > vagrant Regards, Andreas Henriksson
