Hi,

I've had a look at the diff, lgtm.  I'd appreciate the upload to unstable in
due time.  Thanks a lot for your work, much appreciated!

Bye,

Joost


On Thu, Feb 01, 2024 at 10:57:49PM +0000, Steve Langasek wrote:
> Source: liboprf
> Version: 0.1+git20231001.0da3e2b-1
> Severity: serious
> Tags: patch pending
> Justification: library ABI skew on upgrade
> User: debian-...@lists.debian.org
> Usertags: time-t
> 
> NOTICE: these changes must not be uploaded to unstable yet!
> 
> Dear maintainer,
> 
> As part of the 64-bit time_t transition required to support 32-bit
> architectures in 2038 and beyond
> (https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
> liboprf as a source package shipping runtime libraries whose ABI
> either is affected by the change in size of time_t, or could not be
> analyzed via abi-compliance-checker (and therefore to be on the safe
> side we assume is affected).
> 
> To ensure that inconsistent combinations of libraries with their
> reverse-dependencies are never installed together, it is necessary to
> have a library transition, which is most easily done by renaming the
> runtime library package.
> 
> Since turning on 64-bit time_t is being handled centrally through a change
> to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
> important that libraries affected by this ABI change all be uploaded close
> together in time.  Therefore I have prepared a 0-day NMU for liboprf
> which will initially be uploaded to experimental if possible, then to
> unstable after packages have cleared binary NEW.
> 
> Please find the patch for this NMU attached.
> 
> If you have any concerns about this patch, please reach out ASAP.  Although
> this package will be uploaded to experimental immediately, there will be a
> period of several days before we begin uploads to unstable; so if information
> becomes available that your package should not be included in the transition,
> there is time for us to amend the planned uploads.
> 
> 
> 
> -- System Information:
> Debian Release: trixie/sid
>   APT prefers unstable
>   APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 6.5.0-14-generic (SMP w/12 CPU threads; PREEMPT)
> Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
> Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
> Shell: /bin/sh linked to /usr/bin/dash
> Init: systemd (via /run/systemd/system)

> diff -Nru liboprf-0.1+git20231001.0da3e2b/debian/changelog 
> liboprf-0.1+git20231001.0da3e2b/debian/changelog
> --- liboprf-0.1+git20231001.0da3e2b/debian/changelog  2023-10-04 
> 14:07:26.000000000 +0000
> +++ liboprf-0.1+git20231001.0da3e2b/debian/changelog  2024-02-01 
> 17:51:25.000000000 +0000
> @@ -1,3 +1,10 @@
> +liboprf (0.1+git20231001.0da3e2b-1.1) experimental; urgency=medium
> +
> +  * Non-maintainer upload.
> +  * Rename libraries for 64-bit time_t transition.
> +
> + -- Steve Langasek <vor...@debian.org>  Thu, 01 Feb 2024 17:51:25 +0000
> +
>  liboprf (0.1+git20231001.0da3e2b-1) unstable; urgency=low
>  
>    * New upstream git snapshot (thanks again Thorsten Alteholz for
> diff -Nru liboprf-0.1+git20231001.0da3e2b/debian/control 
> liboprf-0.1+git20231001.0da3e2b/debian/control
> --- liboprf-0.1+git20231001.0da3e2b/debian/control    2023-10-04 
> 14:07:26.000000000 +0000
> +++ liboprf-0.1+git20231001.0da3e2b/debian/control    2024-02-01 
> 17:51:25.000000000 +0000
> @@ -10,7 +10,10 @@
>  Vcs-Browser: https://salsa.debian.org/debian/liboprf
>  Vcs-Git: https://salsa.debian.org/debian/liboprf.git
>  
> -Package: liboprf0
> +Package: liboprf0t64
> +Provides: ${t64:Provides}
> +Replaces: liboprf0
> +Breaks: liboprf0 (<< ${source:Version})
>  Section: libs
>  Architecture: any
>  Multi-Arch: same
> diff -Nru liboprf-0.1+git20231001.0da3e2b/debian/liboprf0.install 
> liboprf-0.1+git20231001.0da3e2b/debian/liboprf0.install
> --- liboprf-0.1+git20231001.0da3e2b/debian/liboprf0.install   2023-10-04 
> 14:07:26.000000000 +0000
> +++ liboprf-0.1+git20231001.0da3e2b/debian/liboprf0.install   1970-01-01 
> 00:00:00.000000000 +0000
> @@ -1,2 +0,0 @@
> -#!/usr/bin/dh-exec
> -usr/lib/liboprf.so.0 => usr/lib/${DEB_HOST_MULTIARCH}/liboprf.so.0
> diff -Nru liboprf-0.1+git20231001.0da3e2b/debian/liboprf0t64.install 
> liboprf-0.1+git20231001.0da3e2b/debian/liboprf0t64.install
> --- liboprf-0.1+git20231001.0da3e2b/debian/liboprf0t64.install        
> 1970-01-01 00:00:00.000000000 +0000
> +++ liboprf-0.1+git20231001.0da3e2b/debian/liboprf0t64.install        
> 2023-10-04 14:07:26.000000000 +0000
> @@ -0,0 +1,2 @@
> +#!/usr/bin/dh-exec
> +usr/lib/liboprf.so.0 => usr/lib/${DEB_HOST_MULTIARCH}/liboprf.so.0
> diff -Nru 
> liboprf-0.1+git20231001.0da3e2b/debian/liboprf0t64.lintian-overrides 
> liboprf-0.1+git20231001.0da3e2b/debian/liboprf0t64.lintian-overrides
> --- liboprf-0.1+git20231001.0da3e2b/debian/liboprf0t64.lintian-overrides      
> 1970-01-01 00:00:00.000000000 +0000
> +++ liboprf-0.1+git20231001.0da3e2b/debian/liboprf0t64.lintian-overrides      
> 2024-02-01 17:51:25.000000000 +0000
> @@ -0,0 +1 @@
> +liboprf0t64: package-name-doesnt-match-sonames liboprf0
> diff -Nru liboprf-0.1+git20231001.0da3e2b/debian/rules 
> liboprf-0.1+git20231001.0da3e2b/debian/rules
> --- liboprf-0.1+git20231001.0da3e2b/debian/rules      2023-10-04 
> 14:07:26.000000000 +0000
> +++ liboprf-0.1+git20231001.0da3e2b/debian/rules      2024-02-01 
> 17:51:25.000000000 +0000
> @@ -7,7 +7,7 @@
>  export DEB_LDFLAGS_MAINT_APPEND = -lsodium
>  
>  %:
> -     dh $@ -p liboprf-dev -p liboprf0
> +     dh $@
>  
>  override_dh_auto_install:
>       dh_auto_install -- PREFIX=/usr

Reply via email to