Source: mcrypt
Version: 2.6.8-6
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -o gaaout.o -c gaaout.c -DLOCALEDIR=\"/usr/share/locale\" -I../intl -g 
> -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -I/usr/include -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -I. -I..
> getpass.c: In function ‘readpass’:
> getpass.c:98:18: warning: the comparison will always evaluate as ‘false’ for 
> the address of ‘input’ will never be NULL [-Waddress]
>    98 |         if (input==NULL) return NULL;
>       |                  ^~
> getpass.c:93:21: note: ‘input’ declared here
>    93 |         static char input[MAXLEN + 1];
>       |                     ^~~~~
> getpass.c:104:12: warning: pointer targets in assignment from ‘char *’ to 
> ‘unsigned char *’ differ in signedness [-Wpointer-sign]
>   104 |         ap = asterix;
>       |            ^
> rfc2440.c: In function ‘dek_load’:
> rfc2440.c:566:42: warning: pointer targets in passing argument 5 of 
> ‘mhash_keygen_ext’ differ in signedness [-Wpointer-sign]
>   566 |                            DIM (d->key), pass, strlen(pass));
>       |                                          ^~~~
>       |                                          |
>       |                                          char *
> In file included from /usr/include/mhash.h:10,
>                  from ./defines.h:8,
>                  from rfc2440.c:18:
> /usr/include/mutils/mhash.h:108:45: note: expected ‘uint8_t *’ {aka ‘unsigned 
> char *’} but argument is of type ‘char *’
>   108 |                               mutils_word8 *password, mutils_word32 
> passwordlen);
>       |                                             ^
> rfc2440.c: In function ‘dek_create’:
> rfc2440.c:617:42: warning: pointer targets in passing argument 5 of 
> ‘mhash_keygen_ext’ differ in signedness [-Wpointer-sign]
>   617 |                            DIM (d->key), pass, strlen(pass));
>       |                                          ^~~~
>       |                                          |
>       |                                          char *
> /usr/include/mutils/mhash.h:108:45: note: expected ‘uint8_t *’ {aka ‘unsigned 
> char *’} but argument is of type ‘char *’
>   108 |                               mutils_word8 *password, mutils_word32 
> passwordlen);
>       |                                             ^
> rfc2440.c: In function ‘symkey_enc_decode’:
> rfc2440.c:635:27: warning: pointer targets in passing argument 2 of 
> ‘header_decode’ differ in signedness [-Wpointer-sign]
>   635 |     header_decode(dat->d, &tag, &headlen, &offset, NULL);
>       |                           ^~~~
>       |                           |
>       |                           int *
> rfc2440.c:426:41: note: expected ‘uint32 *’ {aka ‘unsigned int *’} but 
> argument is of type ‘int *’
>   426 | header_decode(const uchar *buf, uint32 *tag, uint32 *len,
>       |                                 ~~~~~~~~^~~
> rfc2440.c:635:33: warning: pointer targets in passing argument 3 of 
> ‘header_decode’ differ in signedness [-Wpointer-sign]
>   635 |     header_decode(dat->d, &tag, &headlen, &offset, NULL);
>       |                                 ^~~~~~~~
>       |                                 |
>       |                                 int *
> rfc2440.c:426:54: note: expected ‘uint32 *’ {aka ‘unsigned int *’} but 
> argument is of type ‘int *’
>   426 | header_decode(const uchar *buf, uint32 *tag, uint32 *len,
>       |                                              ~~~~~~~~^~~
> rfc2440.c:635:43: warning: pointer targets in passing argument 4 of 
> ‘header_decode’ differ in signedness [-Wpointer-sign]
>   635 |     header_decode(dat->d, &tag, &headlen, &offset, NULL);
>       |                                           ^~~~~~~
>       |                                           |
>       |                                           int *
> rfc2440.c:427:23: note: expected ‘uint32 *’ {aka ‘unsigned int *’} but 
> argument is of type ‘int *’
>   427 |               uint32 *headlen, PACKET *pkt)
>       |               ~~~~~~~~^~~~~~~
> rfc2440.c: In function ‘file_to_buf’:
> rfc2440.c:123:5: warning: ignoring return value of ‘fread’ declared with 
> attribute ‘warn_unused_result’ [-Wunused-result]
>   123 |     fread(buf, 1, len, fp);
>       |     ^~~~~~~~~~~~~~~~~~~~~~
> mcrypt.gaa: In function ‘gaa_try’:
> mcrypt.gaa:109:3: error: implicit declaration of function ‘mcrypt_license’; 
> did you mean ‘mcrypt_free’? [-Werror=implicit-function-declaration]
>   109 | option (L, license) { mcrypt_license(); exit(0); } "Displays license 
> information."
>       |   ^~~~~~~~~~~~~~
>       |   mcrypt_free
> mcrypt.gaa:108:3: error: implicit declaration of function ‘mcrypt_version’; 
> did you mean ‘mcrypt_perror’? [-Werror=implicit-function-declaration]
>   108 | option (v, version) { mcrypt_version(); exit(0); } "Prints the 
> version number"
>       |   ^~~~~~~~~~~~~~
>       |   mcrypt_perror
> mcrypt.gaa:107:3: error: implicit declaration of function ‘usage’ 
> [-Werror=implicit-function-declaration]
>   107 | option (help) { usage(); exit(0); } "Prints this help"
>       |   ^~~~~
> mcrypt.gaa:99:3: error: implicit declaration of function ‘print_hashlist’ 
> [-Werror=implicit-function-declaration]
>    99 | option (list-hash) { print_hashlist(); exit(0); } "Prints a list of 
> the supported hash algorithms."
>       |   ^~~~~~~~~~~~~~
> mcrypt.gaa:98:3: error: implicit declaration of function ‘print_keylist’ 
> [-Werror=implicit-function-declaration]
>    98 | option (list-keymodes) { print_keylist(); exit(0); } "Prints a list 
> of the supported key modes."
>       |   ^~~~~~~~~~~~~
> mcrypt.gaa:97:3: error: implicit declaration of function ‘print_list’ 
> [-Werror=implicit-function-declaration]
>    97 | option (list) { print_list(); exit(0); } "Prints a list of the 
> supported algorithms and modes."
>       |   ^~~~~~~~~~
> gaa.skel: At top level:
> gaa.skel:339:14: warning: ‘gaa_getfloat’ defined but not used 
> [-Wunused-function]
> gaa.skel:325:13: warning: ‘gaa_getchar’ defined but not used 
> [-Wunused-function]
> cc1: some warnings being treated as errors
> make[3]: *** [Makefile:738: gaaout.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/mcrypt_2.6.8-6_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

Reply via email to