Source: kali
Version: 3.1+dfsg-1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> cc -DXFORM -Wdate-time -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -Wall   -Wdate-time 
> -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64  -c -o printmain.o printmain.c
> printmain.c: In function ‘main’:
> printmain.c:42:5: warning: ignoring return value of ‘fscanf’ declared with 
> attribute ‘warn_unused_result’ [-Wunused-result]
>    42 |     fscanf(pat,"%d\n",&i);
>       |     ^~~~~~~~~~~~~~~~~~~~~
> printmain.c:48:5: warning: ignoring return value of ‘fscanf’ declared with 
> attribute ‘warn_unused_result’ [-Wunused-result]
>    48 |     fscanf(pat,"%f %f\n",&win_rect.width,&win_rect.height);
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> printmain.c:49:5: warning: ignoring return value of ‘fscanf’ declared with 
> attribute ‘warn_unused_result’ [-Wunused-result]
>    49 |     fscanf(pat,"%f %f\n",&(sym->v1.x),&(sym->v1.y));
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> printmain.c:50:5: warning: ignoring return value of ‘fscanf’ declared with 
> attribute ‘warn_unused_result’ [-Wunused-result]
>    50 |     fscanf(pat,"%f %f\n",&(sym->v2.x),&(sym->v2.y));
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> printmain.c:51:5: warning: ignoring return value of ‘fscanf’ declared with 
> attribute ‘warn_unused_result’ [-Wunused-result]
>    51 |     fscanf(pat,"%f\n",&scale);
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~
> xio.c: In function ‘winopen’:
> xio.c:159:15: error: implicit declaration of function ‘strlen’ 
> [-Werror=implicit-function-declaration]
>   159 |   tp.nitems = strlen(title);
>       |               ^~~~~~
> xio.c:55:1: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
>    54 | #include <X11/Xatom.h>
>   +++ |+#include <string.h>
>    55 | 
> xio.c:159:15: warning: incompatible implicit declaration of built-in function 
> ‘strlen’ [-Wbuiltin-declaration-mismatch]
>   159 |   tp.nitems = strlen(title);
>       |               ^~~~~~
> xio.c:159:15: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
> psio.c: In function ‘PrintOut’:
> psio.c:58:7: warning: unused variable ‘i’ [-Wunused-variable]
>    58 |   int i;
>       |       ^
> xio.c: In function ‘GXDrawPoints’:
> xio.c:387:7: warning: ‘v2f’ accessing 8 bytes in a region of size 4 
> [-Wstringop-overflow=]
>   387 |       v2f(&obj[i].x);
>       |       ^~~~~~~~~~~~~~
> xio.c:387:7: note: referencing argument 1 of type ‘float[2]’
> xio.c:296:1: note: in a call to function ‘v2f’
>   296 | v2f(float p[2])
>       | ^~~
> symmetry.c: In function ‘SetUpSymmetry’:
> symmetry.c:362:9: warning: unused variable ‘i’ [-Wunused-variable]
>   362 |     int i;
>       |         ^
> symmetry.c: In function ‘MakeCurrentObject’:
> symmetry.c:520:42: warning: operation on ‘glide[0].y’ may be undefined 
> [-Wsequence-point]
>   520 |     glide[0].x = glide[1].x = glide[0].y = glide[0].y = 0.0;
>       |                               ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
> symmetry.c:508:9: warning: unused variable ‘j’ [-Wunused-variable]
>   508 |   int i,j,pos_count;
>       |         ^
> symmetry.c: In function ‘MatrixMultiply’:
> symmetry.c:760:7: warning: unused variable ‘i’ [-Wunused-variable]
>   760 |   int i;
>       |       ^
> kali.c: In function ‘handleRedraw’:
> kali.c:124:3: error: implicit declaration of function ‘reshapeviewport’ 
> [-Werror=implicit-function-declaration]
>   124 |   reshapeviewport();
>       |   ^~~~~~~~~~~~~~~
> kali.c:131:3: error: implicit declaration of function ‘swapbuffers’; did you 
> mean ‘setbuffer’? [-Werror=implicit-function-declaration]
>   131 |   swapbuffers();
>       |   ^~~~~~~~~~~
>       |   setbuffer
> kali.c: In function ‘doRedraw’:
> kali.c:148:5: error: implicit declaration of function ‘user_event_cb’ 
> [-Werror=implicit-function-declaration]
>   148 |     user_event_cb(&newev, NULL);
>       |     ^~~~~~~~~~~~~
> kali.c: In function ‘handleKeyboard’:
> kali.c:273:13: error: implicit declaration of function ‘StartLoadProc’; did 
> you mean ‘LoadProc’? [-Werror=implicit-function-declaration]
>   273 |   case '<': StartLoadProc(NULL, 0); break;
>       |             ^~~~~~~~~~~~~
>       |             LoadProc
> kali.c:275:13: error: implicit declaration of function ‘StartSaveProc’; did 
> you mean ‘SaveProc’? [-Werror=implicit-function-declaration]
>   275 |   case '>': StartSaveProc(NULL, 0); break;
>       |             ^~~~~~~~~~~~~
>       |             SaveProc
> kali.c:277:13: error: implicit declaration of function ‘set_mode’ 
> [-Werror=implicit-function-declaration]
>   277 |   case 'z': set_mode(KALIZOOM); break;
>       |             ^~~~~~~~
> kali.c: In function ‘user_event_cb’:
> kali.c:333:10: warning: variable ‘y’ set but not used 
> [-Wunused-but-set-variable]
>   333 |   int x, y, how = 0, button;
>       |          ^
> kali.c:333:7: warning: variable ‘x’ set but not used 
> [-Wunused-but-set-variable]
>   333 |   int x, y, how = 0, button;
>       |       ^
> kali.c: In function ‘main’:
> kali.c:465:3: error: implicit declaration of function ‘foreground’; did you 
> mean ‘XNForeground’? [-Werror=implicit-function-declaration]
>   465 |   foreground();
>       |   ^~~~~~~~~~
>       |   XNForeground
> kali.c:474:3: error: implicit declaration of function ‘forms_init’; did you 
> mean ‘flps_init’? [-Werror=implicit-function-declaration]
>   474 |   forms_init(&pwin);
>       |   ^~~~~~~~~~
>       |   flps_init
> kali.c:475:3: error: implicit declaration of function ‘winset’ 
> [-Werror=implicit-function-declaration]
>   475 |   winset(win);
>       |   ^~~~~~
> kali.c:476:10: error: implicit declaration of function ‘load_a_file’ 
> [-Werror=implicit-function-declaration]
>   476 |   if (f) load_a_file(f);
>       |          ^~~~~~~~~~~
> kali.c: In function ‘DrawCurrent’:
> kali.c:61:25: error: implicit declaration of function ‘cpack’ 
> [-Werror=implicit-function-declaration]
>    61 | #define SET_COLOR       cpack
>       |                         ^~~~~
> kali.c:573:3: note: in expansion of macro ‘SET_COLOR’
>   573 |   SET_COLOR(BACKCOLOR);
>       |   ^~~~~~~~~
> kali.c:574:3: error: implicit declaration of function ‘clear’; did you mean 
> ‘GXclear’? [-Werror=implicit-function-declaration]
>   574 |   clear();
>       |   ^~~~~
>       |   GXclear
> kali.c: In function ‘MakeWindow’:
> kali.c:636:3: error: implicit declaration of function ‘GXinit’ 
> [-Werror=implicit-function-declaration]
>   636 |   GXinit(&GXDraw, fl_display, 0);
>       |   ^~~~~~
> kali.c:639:3: error: implicit declaration of function ‘RGBmode’ 
> [-Werror=implicit-function-declaration]
>   639 |   RGBmode();
>       |   ^~~~~~~
> kali.c:641:3: error: implicit declaration of function ‘winconstraints’ 
> [-Werror=implicit-function-declaration]
>   641 |   winconstraints();
>       |   ^~~~~~~~~~~~~~
> callbacks.c: In function ‘forms_init’:
> callbacks.c:181:3: error: implicit declaration of function ‘winset’; did you 
> mean ‘fl_winset’? [-Werror=implicit-function-declaration]
>   181 |   winset(fl_show_form(KaliForm, FL_PLACE_FREE, TRUE, "Symmetry 
> Groups"));
>       |   ^~~~~~
>       |   fl_winset
> kali.c:643:3: error: implicit declaration of function ‘doublebuffer’ 
> [-Werror=implicit-function-declaration]
>   643 |   doublebuffer();
>       |   ^~~~~~~~~~~~
> kali.c:644:3: error: implicit declaration of function ‘gconfig’ 
> [-Werror=implicit-function-declaration]
>   644 |   gconfig();
>       |   ^~~~~~~
> kali.c: In function ‘AdjustWindowRectangle’:
> kali.c:652:3: error: implicit declaration of function ‘getsize’; did you mean 
> ‘getline’? [-Werror=implicit-function-declaration]
>   652 |   getsize(&x,&y);
>       |   ^~~~~~~
>       |   getline
> kali.c: In function ‘PrintLine’:
> kali.c:674:12: warning: format ‘%x’ expects argument of type ‘unsigned int’, 
> but argument 2 has type ‘LINE *’ {aka ‘struct s_line *’} [-Wformat=]
>   674 |   printf("%x ",l);
>       |           ~^   ~
>       |            |   |
>       |            |   LINE * {aka struct s_line *}
>       |            unsigned int
> kali.c:676:15: warning: format ‘%x’ expects argument of type ‘unsigned int’, 
> but argument 3 has type ‘LINE *’ {aka ‘struct s_line *’} [-Wformat=]
>   676 |   printf("%d %x \n",l->id,l->next);
>       |              ~^           ~~~~~~~
>       |               |            |
>       |               unsigned int LINE * {aka struct s_line *}
> kali.c: In function ‘DefineSymWindow’:
> kali.c:749:11: warning: unused variable ‘y’ [-Wunused-variable]
>   749 |   float x,y;
>       |           ^
> kali.c:749:9: warning: unused variable ‘x’ [-Wunused-variable]
>   749 |   float x,y;
>       |         ^
> kali.c: In function ‘user_event_cb’:
> kali.c:396:1: warning: control reaches end of non-void function 
> [-Wreturn-type]
>   396 | }
>       | ^
> kali.c: In function ‘LoadProc’:
> kali.c:724:3: warning: ignoring return value of ‘fscanf’ declared with 
> attribute ‘warn_unused_result’ [-Wunused-result]
>   724 |   fscanf(pat,"%d\n",&sym_index);
>       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> kali.c:725:3: warning: ignoring return value of ‘fscanf’ declared with 
> attribute ‘warn_unused_result’ [-Wunused-result]
>   725 |   fscanf(pat,"%f %f\n",&dummy,&dummy);
>       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> kali.c:727:3: warning: ignoring return value of ‘fscanf’ declared with 
> attribute ‘warn_unused_result’ [-Wunused-result]
>   727 |   fscanf(pat,"%f %f\n",
>       |   ^~~~~~~~~~~~~~~~~~~~~
>   728 |          &(sym->v1.x),&(sym->v1.y));
>       |          ~~~~~~~~~~~~~~~~~~~~~~~~~~
> kali.c:729:3: warning: ignoring return value of ‘fscanf’ declared with 
> attribute ‘warn_unused_result’ [-Wunused-result]
>   729 |   fscanf(pat,"%f %f\n",
>       |   ^~~~~~~~~~~~~~~~~~~~~
>   730 |          &(sym->v2.x),&(sym->v2.y));
>       |          ~~~~~~~~~~~~~~~~~~~~~~~~~~
> kali.c:731:3: warning: ignoring return value of ‘fscanf’ declared with 
> attribute ‘warn_unused_result’ [-Wunused-result]
>   731 |   fscanf(pat,"%f \n",
>       |   ^~~~~~~~~~~~~~~~~~~
>   732 |          &zoom);
>       |          ~~~~~~
> kali.c: At top level:
> kali.c:169:13: warning: ‘modechars’ defined but not used [-Wunused-variable]
>   169 | static char modechars[] = "?dcptmza/rD";  /* draw, cut, pick, 
> transform,
>       |             ^~~~~~~~~
> callbacks.c:182:3: error: implicit declaration of function ‘winconstraints’ 
> [-Werror=implicit-function-declaration]
>   182 |   winconstraints();
>       |   ^~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[2]: *** [<builtin>: xio.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/kali_3.1+dfsg-1_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

Reply via email to