On Sun, Mar 17, 2024 at 06:53:34AM +0100, Emanuele Rocca wrote: > > On 2024-03-16 04:21, Emanuele Rocca wrote: > > With libcurl3t64-gnutls cargo can now be rebootstrapped on armhf > > And on armel too. Fixed armhf/armel packages uploaded. > > > Fabian: it seems that cargo's build-depend on git can be dropped? The > > package builds fine without, tests included. > > I haven't touched build-depends and git is still currently > uninstallable. For this reason cargo would not cleanly build from source > on armhf/armel in case of sourceful upload, but as I said without git it > does build fine. Leaving this one up to Fabian!
it is only used for some tests, and does are properly guarded to be skipped if git is not around: $ rg requires_git tests/testsuite/git.rs 2713:#[cargo_test(requires_git)] 2816:#[cargo_test(requires_git)] 2873:#[cargo_test(requires_git)] tests/testsuite/git_gc.rs 92:#[cargo_test(requires_git)] or, from a build log with git removed from d/control: $ rg '^test git.*ignored' ../cargo_0.70.1*-17T*.build ../cargo_0.70.1+ds1-2_amd64-2024-03-17T07:49:03Z.build 4480:test git::git_fetch_cli_env_clean ... ignored, git not installed 4483:test git::git_with_cli_force ... ignored, git not installed 4504:test git::use_the_cli ... ignored, git not installed 4510:test git_gc::use_git_gc ... ignored, git not installed that being said, these tests are for the opt-in feature of cargo using the git binary/CLI instead of libgit2 (or, in more recent versions, gitoxide) for various git related operations (fetching crates.io index if not opting into the sparse index feature, fetching git dependencies in Cargo.toml, ..). I don't expect that to break, but obviously while git is not installable that feature of cargo is unavailable as well. So a rebootstrap without git present seems okay if that speeds up things.
