[adding <deb...@tomlee.co> to CC]
Sylvain Joubert wrote:
> The CMake config provided by this package seems incompatible with the upstream
> one.
> Currently, the package provides data under the name "Hiredis" with a capital
> leading H, while upstream is named "hiredis" lowercase
> ".../cmake/Hiredis/HiredisConfig{,Version}.cmake" vs.
> ".../cmake/hiredis/hiredis-config.cmake" (see
> https://github.com/redis/hiredis/blob/master/CMakeLists.txt#L137-L150)
>
> This means that a client CMake project can't switch transparently between an
> Debian install and a custom cmake build of hiredis.
>
> Could you rename the cmake configuration provided by Debian to match upstream,
> or even build hiredis using the official CMake support?
I'm looping in Tom Lee here as they added the CMake changes back in
2018 (via #784768?).
Yes, perhaps these changes are simply not needed anymore. However, I
don't quite understand the changes made in 07_cmake.patch completely
to make a determination on my own. I think I might know how to fix
this (eg. change the definition of CMAKE_PATH and then update
libhiredis-dev.install to match?), but, again, I'm just not familiar
enough.
No objection to solving this issue in a general sense, though. :)
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org 🍥 chris-lamb.co.uk
`-
