control: tag -1 + pending control: close 1067133 Hello,
On Wed 20 Mar 2024 at 12:06am -07, Xiyue Deng wrote: > Found the upstream fix for the test failures[1]. I have backported the > patch in [2] In the future, especially with dgit-maint-merge(7), it's a good idea to use 'git cherry-pick -x' to backport upstream patches like this, so that it's easily traceable by others. In lieu of this, I've added a note of the upstream commit in d/changelog. > Meanwhile, it looks like I was jumping to conclusion a little too > soon. TL;DR it will still get stuck without running in the source > directory. So IMHO disabling autopkgtest would be a sensible choice, > which I did in [3]. > > Also built and uploaded the latest version to mentors[4]. PTAL. TIA! > > Longer analysis of tests getting stuck: > > Comparing working and not working settings using strace, I noticed that > during buttercup tests it would get stuck closing > test/clojure-mode-refactor-rename-ns-alias-test.el, which I still didn't > know why unfortunately. If I disabled/renamed this file, buttercup > would finish running, and would fail due to unable to load clojure-mode > in the source tree. And yes, specifically the file in the source tree > as in the following error message: > > ,---- > | Cannot open load file: No such file or directory, > | /home/manphiz/Projects/debian-packaging/clojure-mode/clojure-mode > `---- > > I even tried directly using `--eval "(load-library \"clojure-mode\")"` > which actually succeeded, but it still failed with the same error. > Given this I would have to assume that buttercup requires running in the > source tree. It's likely possible to patch the tests; I doubt it's fundamental to Buttercup. Thanks for adopting the package. -- Sean Whitton
signature.asc
Description: PGP signature
