* Holger Levsen <hol...@layer-acht.org> [2024-04-15 12:13]: > I've got two remaining questions about libscout (and diffoscope) > > On Thu, Apr 11, 2024 at 01:48:18AM +0200, Fay Stegerman wrote: > > unzip does seem to extract all the files, though it errors out. Not sure > > what > > diffoscope should do here. This is definitely a broken ZIP file. That bug > > should probably be reported against libscout or whatever tooling it used to > > create that JAR. > > you filed https://github.com/python/cpython/issues/117779 > (thanks again!), am I correct to assume that thus there's no need > to file a seperate bug against libscout?
It's generating a broken ZIP file with duplicate entries. It really shouldn't be doing that, regardless of whether we can extract the files nonetheless. That's still a bug that should be reported and fixed. > and 2nd, > https://tests.reproducible-builds.org/debian/rb-pkg/unstable/arm64/diffoscope-results/libscout.html > now as expected displays: > > './usr/share/java/libscout.jar' has 35 duplicate entries > './usr/share/java/libscout.jar' has 35 duplicate entries > > (which is nice, though maybe could only been shown once?) Ah. It correctly shows that twice as there could be differences between the two files being compared wrt whether they have duplicate entries (and if so how many). And if you run 'diffoscope foo.zip bar.zip' it'll show those two different file names. But in this case we have nested archives and the path (and in this case also the number of duplicate entries) is identical for both, so maybe we can tweak the output to show which top-level file it belongs to? > but > https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/arm64/diffoscope-results/libscout.html > shows this: > > Command `'zipdetails --redact --scan --utc {}'` failed with exit code 255. > Standard output: [...] > though this later is done using diffoscope from unstable while the > rest of the userland is bullseye, so this might be expected as well? Ah. Looks like zipdetails(1) on bullseye doesn't support the --redact, --scan, and --utc options yet. - Fay
