control: tags -1 patch
control: forwarded -1 https://github.com/ROCm/rocThrust/pull/402

Looks like the build went fine
G.
On Tue, 16 Apr 2024 09:06:27 +0200 Gianfranco Costamagna 
<locutusofb...@debian.org> wrote:
Hello,
On Mon, 15 Apr 2024 16:31:39 -0600 Cordell Bloor <c...@slerp.xyz> wrote:
> Hi Timo,
> > On Sat, 2 Mar 2024 09:21:43 +0100 Timo =?utf-8?Q?R=C3=B6hling?= > <roehl...@debian.org> wrote: > > >
>  > On Sun, 25 Feb 2024 20:28:53 +0100 Lucas Nussbaum <lu...@debian.org>
>  > wrote:
>  > > > /usr/include/thrust/detail/type_traits.h:736:1: error: expected
>  > > > type-specifier before ‘template’
>  >
>  > This bug is caused by a #ifdef cascade for different
>  > THRUST_DEVICE_SYSTEM values, which sadly no longer works with
>  > THRUST_DEVICE_SYSTEM_OMP. This makes it effectively impossible to
>  > build the HIP backend and the OpenMP backend from the same source.
> > Am I understanding correctly that this was broken in a rocthrust update? > Should this be treated as a rocthrust bug? [1] > > Sincerely,
> Cory Bloor
>

I agree with Cory, to me looks also a regression in thrust

I'm trying some hacky patch, lets see

Description: Reintroduce fallback lost in 
https://github.com/ROCm/rocThrust/commit/2b80e29803d60f01701a67bc57ef06dacfe8af8b
Author: Gianfranco Costamagna <locutusofb...@debian.org>
Last-Update: 2024-04-16

--- rocthrust-5.7.1.orig/thrust/detail/type_traits.h
+++ rocthrust-5.7.1/thrust/detail/type_traits.h
@@ -731,6 +731,8 @@ using invoke_result_t =
  #else // 2017+
    ::cuda::std::invoke_result_t<Invokable, Args...>;
  #endif
+#else
+  std::invoke_result_t<Invokable, Args...>;
  #endif

  template <class F, class... Us>

> [1]: https://bugs.debian.org/1064730
> > >

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to