Hi, Dylan! On Fri, Apr 05, 2024 at 09:28:02PM +0200, Dylan Aïssi wrote: > Hi, > > Le ven. 5 avr. 2024 à 16:00, Dylan Aïssi <bob.dyb...@gmail.com> a écrit : > > Meanwhile, I pinged upstream to ask for their opinion about > > that to make sure we are not going to break stuff. > > launcher-libseat has an higher priority than launcher-logind, > that means enabling launcher-libseat will change the default > behavior for all users. Although this should be harmless > because libseat should contact logind, it doesn't work for > whatever reason. I just tested with a VM without a > graphical login. I can launch weston 10.0.1-1, but > it fails with 10.0.1-1+deb12u1. So, I guess it would > require more changes unsuitable for bookworm :-(
First of all, thanks for being so helpful in this wishlist bug! I did some investigation on weston and turns out out it's pretty easy to change the launcher order weston uses (see attached patch). I tested it with a debian12 vm and weston comes up correctly using systemd-logind. As you said, without this patch, it doesn't. I also did the ABI compatibility analysis and it's 100% compatible with bookworm's weston. I think it's a harmless patch, but it would be nice if you could ping upstream about it. Also, now we have a patch and a new feature so maybe you think it's too much for a stable update. Is there a formal procedure to enter Debian's X strike force? Do you usually use a mailing list or maybe irc? Is there a wiki with more documentation? I'm spending quite some time looking at it's package so I might as well try to contribute :-) > > Best, > Dylan Cheers, Charles
From 8d77f72ef669db60a11c9e5e2dd491a638ba76f8 Mon Sep 17 00:00:00 2001 From: Carlos Henrique Lima Melara <carlos.mel...@toradex.com> Date: Thu, 9 May 2024 12:53:47 -0300 Subject: [PATCH] d/p/move-libseat-launch-to-lowest-priority.patch: add new patch --- ...ve-libseat-launch-to-lowest-priority.patch | 39 +++++++++++++++++++ debian/patches/series | 1 + 2 files changed, 40 insertions(+) create mode 100644 debian/patches/move-libseat-launch-to-lowest-priority.patch create mode 100644 debian/patches/series diff --git a/debian/patches/move-libseat-launch-to-lowest-priority.patch b/debian/patches/move-libseat-launch-to-lowest-priority.patch new file mode 100644 index 00000000..e13d090e --- /dev/null +++ b/debian/patches/move-libseat-launch-to-lowest-priority.patch @@ -0,0 +1,39 @@ +From: Carlos Henrique Lima Melara <carlos.mel...@toradex.com> +Date: Thu, 9 May 2024 12:46:45 -0300 +Subject: libweston/launcher-util: move launcher-libseat to lowest priority + +Previously we had launcher-libseat support disabled in bookworm as it was the +default in upstream weston. To enable it and support other init systems not +relying on systemd-logind, we move it to lowest priority. In this way, we can +have the same behaviour as previously for systems with systemd, but also support +systems using libseat for example. + +Fowarded: not-needed +Bug-Debian: https://bugs.debian.org/1066112 +Last-Update: 2024-05-09 +--- + libweston/launcher-util.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/libweston/launcher-util.c b/libweston/launcher-util.c +index b2219b6..24e74cb 100644 +--- a/libweston/launcher-util.c ++++ b/libweston/launcher-util.c +@@ -37,14 +37,14 @@ + #include <linux/input.h> + + static const struct launcher_interface *ifaces[] = { +-#ifdef HAVE_LIBSEAT +- &launcher_libseat_iface, +-#endif + #ifdef HAVE_SYSTEMD_LOGIN + &launcher_logind_iface, + #endif + &launcher_weston_launch_iface, + &launcher_direct_iface, ++#ifdef HAVE_LIBSEAT ++ &launcher_libseat_iface, ++#endif + NULL, + }; + diff --git a/debian/patches/series b/debian/patches/series new file mode 100644 index 00000000..cf9b9c2b --- /dev/null +++ b/debian/patches/series @@ -0,0 +1 @@ +move-libseat-launch-to-lowest-priority.patch -- 2.43.0
signature.asc
Description: PGP signature
