Bug#1070868: vstream-client: make the build system respect Debian compiler flags

[Zixing Liu]

Package: vstream-client
Version: 1.2-7
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu oracular ubuntu-patch

Dear Maintainer,

This patch makes the build system respect Debian compiler flags to ensure
build consistency.

In Ubuntu, the attached patch was applied to achieve the following:

    - Use dpkg-buildflags, and build with -D_LARGEFILE64_SOURCE since
      test-client.c uses fopen64.


Thanks for considering the patch.


-- System Information:
Debian Release: trixie/sid
  APT prefers noble-updates
  APT policy: (500, 'noble-updates'), (500, 'noble-security'), (500, 'noble'), 
(100, 'noble-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.8.0-31-generic (SMP w/10 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_CA:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

diff -Nru vstream-client-1.2/debian/control vstream-client-1.2/debian/control
--- vstream-client-1.2/debian/control   2022-01-16 14:25:17.000000000 -0700
+++ vstream-client-1.2/debian/control   2024-05-10 14:37:40.000000000 -0600
@@ -2,7 +2,8 @@
 Priority: optional
 Maintainer: Paul Hedderly <p...@debian.org>
 Build-Depends: debhelper-compat (= 13),
-               autotools-dev
+               autotools-dev,
+               dpkg-dev
 Standards-Version: 3.9.2
 Vcs-Browser: https://salsa.debian.org/debian/vstream-client
 Vcs-Git: https://salsa.debian.org/debian/vstream-client.git
diff -Nru vstream-client-1.2/debian/rules vstream-client-1.2/debian/rules
--- vstream-client-1.2/debian/rules     2022-01-16 14:25:17.000000000 -0700
+++ vstream-client-1.2/debian/rules     2024-05-10 14:34:09.000000000 -0600
@@ -31,6 +31,10 @@
 #major=`ls src/.libs/lib*.so.* | \
 # awk '{if (match($$0,/\.so\.[0-9]+$$/)) print substr($$0,RSTART+4)}'`
 
+export DEB_CPPFLAGS_MAINT_APPEND := -D_LARGEFILE64_SOURCE
+export DEB_CFLAGS_MAINT_APPEND := -Wall
+include /usr/share/dpkg/buildflags.mk
+
 config.status: configure
        dh_testdir
        # Add here commands to configure the package.
@@ -40,7 +44,7 @@
 ifneq "$(wildcard /usr/share/misc/config.guess)" ""
        cp -f /usr/share/misc/config.guess config.guess
 endif
-       ./configure --prefix=/usr
+       CFLAGS="$(CPPFLAGS) $(CFLAGS)" LDFLAGS="$(LDFLAGS)" ./configure 
--prefix=/usr
        # THIS IS POINTLESS... BECAUSE THE UPSTREAM BUILD SYSTEM IS SIMPLE AND 
MESSY!
 
 #CFLAGS="$(CFLAGS)" LDFLAGS="-Wl,-z,defs"