Control: tags -1 + confirmed patch pending upstream Hi,
gregor herrmann, on 2023-09-09: > # Failed test 'Then analizo must report that the project has > total_abstract_classes = 1' > # at t/features/metrics/abstract_classes.feature line 19. > # in step at t/features/metrics/abstract_classes.feature line 19. > # not ok > # # Failed test at > /build/analizo-1.25.4/t/features/step_definitions/analizo_steps.pl line 143. > # # got: 2 > # # expected: 1 Looking at t/features/metrics/abstract_classes.feature, ther is a curious discrepancy between the csharp and the other languages in terms of expected number of abstract classes: Scenario: "Animals" project Given I am in t/samples/animals/<language> When I run "analizo metrics ." Then analizo must report that the project has total_abstract_classes = <total_abstract_classes> Examples: | language | total_abstract_classes | | cpp | 2 | | java | 2 | | csharp | 1 | Looking at the sample code which is under test, there does seem to be two abstract classes for csharp samples: $ grep 'abstract class' t/samples/animals/csharp/* t/samples/animals/csharp/Animal.cs:public abstract class Animal { t/samples/animals/csharp/Mammal.cs:public abstract class Mammal : Animal { Looking upstream, I ran into the commit introducing the csharp support[1], which suggest there was something off at the time of the introduction of the test with Doxygen: >> doxyparse doesn't identify all abstract C# classes, the Mammal abstract >> class defined in animals sample (below) wasn't identified: >> >> // Mammal.cs: >> public abstract class Mammal : Animal { >> public virtual void close() {} >> } This suggests the issue has been resolved with the recent upload of doxygen that is currently staging in unstable. Therefore, I believe it should be safe to update the test item so analizo is expected to capture 2 abstract classes in csharp as well as the other languages. I am preparing an upload to resolve that. [1]: https://github.com/analizo/analizo/commit/6cdd646d723106bddc4f9f01cbbbf9370e347925 Have a nice day, :) -- .''`. Étienne Mollier <emoll...@debian.org> : :' : pgp: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da `. `' sent from /dev/pts/3, please excuse my verbosity `- on air: Pendragon - The Edge Of The World
signature.asc
Description: PGP signature