> Additionally replaced > setup.py tests with pytest to fix autopkgtests. I have attached the > debdiff containing these changes for your review.
Why is replacing setup.py test with pytest fixing the tests? > diff -Nru python-xmlrunner-3.2.0/debian/rules > python-xmlrunner-3.2.0/debian/rules > --- python-xmlrunner-3.2.0/debian/rules 2023-01-21 20:37:57.000000000 > +0000 > +++ python-xmlrunner-3.2.0/debian/rules 2024-06-09 03:00:00.000000000 > +0000 > @@ -6,3 +6,7 @@ > > %: > dh $@ --with python3 --buildsystem=pybuild > + > +override_dh_auto_install: You can use execute_after_dh_auto_install > + dh_auto_install > + rm -f debian/python3-xmlrunner/usr/LICENSE There is no very strong reason for upstream to install the LICENSE in the upstream package too. Instead of removing it in d/rules, can you patch the code itself and make a PR upstream? > diff -Nru python-xmlrunner-3.2.0/debian/tests/control > python-xmlrunner-3.2.0/debian/tests/control > --- python-xmlrunner-3.2.0/debian/tests/control 2023-01-21 > 20:37:57.000000000 +0000 > +++ python-xmlrunner-3.2.0/debian/tests/control 2024-06-09 > 03:00:00.000000000 +0000 > @@ -1,2 +1,2 @@ > Tests: upstreamtestsuite > -Depends: @, python3-setuptools, python3-django > +Depends: @, python3-pytest, python3-django > diff -Nru python-xmlrunner-3.2.0/debian/tests/upstreamtestsuite > python-xmlrunner-3.2.0/debian/tests/upstreamtestsuite > --- python-xmlrunner-3.2.0/debian/tests/upstreamtestsuite 2023-01-21 > 20:37:57.000000000 +0000 > +++ python-xmlrunner-3.2.0/debian/tests/upstreamtestsuite 2024-06-09 > 03:00:00.000000000 +0000 > @@ -1,3 +1,4 @@ > #!/bin/sh > set -e > -python3 setup.py test 2>&1 > +# Disabled two tests -AttributeError need further investigation. You disabled 2 tests that are passing at build time. That means there's something wrong with the way autopkgtests are run or something else. Can you try to fix the autopkgtests w/o skipping anything? > +pytest -k "not test_basic_unittest_constructs and not > test_unexpected_success" Best, Nilesh
signature.asc
Description: PGP signature
