Mateusz, I am very impressed with your packaging skills. I have just a few small recommendations that should be easy to resolve. Once they are, I will be happy to sponsor your package.
1. The copy of the code you have uploaded to Mentors is significantly different than what you are hosting on https://github.com/mati75/vimb. Please push your changes to the repository. When uploading a package, I prefer to build it from the source code listed in the Vcs-Git entry in debian/control. As a side note, you might consider hosting your packaging code on salsa.debian.org, but that is not a requirement. 1. Please add an upstream metadata file. You can find documentation at: https://wiki.debian.org/UpstreamMetadata You can see an example in one of my packages at: https://salsa.debian.org/soren/privacybrowser/-/blob/master/debian/upstream/ metadata?ref_type=heads You don’t need to populate all the possible fields; just those that make sense for the project. A list of all possible fields is at: https://dep-team.pages.debian.net/deps/dep12/ 2. The version of lintian in unstable is newer than the one on Mentors. As such, it catches a few problems Mentors doesn’t see. I: vimb: acute-accent-in-manual-page [usr/share/man/man1/vimb.1.gz:549] N: N: This manual page uses the \' groff sequence. Usually, the intent is to N: generate an apostrophe, but that sequence actually renders as an acute N: accent. N: N: For an apostrophe or a single closing quote, use plain '. For single N: opening quote, i.e. a straight downward line ' like the one used in shell N: commands, use '\(aq'. N: N: In case this tag was emitted for the second half of a '\\' sequence, this N: is indeed no acute accent, but still wrong: A literal backslash should be N: written \e in the groff format, i.e. a '\\' sequence needs to be changed N: to '\e' which also won't trigger this tag. N: N: Please refer to Bug#554897, Bug#507673, and Bug#966803 for details. N: N: Visibility: info N: Show-Always: no N: Check: documentation/manual N: Renamed from: acute-accent-in-manpage N: N: I: vimb: acute-accent-in-manual-page [usr/share/man/man1/vimb.1.gz:807] If you like, you can submit a fix upstream and then add a patch to clean it up locally. Once the upstream fix is applied, you can drop your local patch. 3. I: vimb: typo-in-manual-page everytime every time [usr/share/man/man1/vimb. 1.gz:970] N: N: Lintian found a spelling error in a manual page. Lintian has a list of N: common misspellings that it looks for. It does not have a dictionary like N: a spelling checker does. N: N: If the string containing the spelling error is translated with the help of N: gettext (with the help of po4a, for example) or a similar tool, please fix N: the error in the translations as well as the English text to avoid making N: the translations fuzzy. With gettext, for example, this means you should N: also fix the spelling mistake in the corresponding msgids in the *.po N: files. N: N: Visibility: info N: Show-Always: no N: Check: documentation/manual N: Renamed from: spelling-error-in-manpage "Everytime" should be written as two words, “every time”. This could be temporarily fixed with a patch the same as number 2 above. 4. I: vimb: desktop-entry-lacks-keywords-entry [usr/share/applications/ vimb.desktop] N: N: This .desktop file is either missing a Keywords entry, or it does not N: contain keywords above and beyond those already present in the Name or N: GenericName entries. N: N: The Keywords field is intended to show keywords relevant for a .desktop N: file. N: N: Desktop files are organized in key-value pairs and are similar to INI N: files. N: N: The desktop-file-validate tool in the desktop-file-utils package may be N: useful when checking the syntax of desktop entries. N: N: Please refer to N: https://specifications.freedesktop.org/desktop-entry-spec/latest/ ar01s06.html, N: Bug#693918, and N: https://wiki.gnome.org/Initiatives/GnomeGoals/DesktopFileKeywords for N: details. N: N: Visibility: info N: Show-Always: no N: Check: menu-format You should take a look at this and decide if there are any keywords that would apply that are not already in the Name or GenericName entries. If not, you can add an override. I did this for one of my packages. https://salsa.debian.org/soren/privacybrowser/-/blob/master/debian/lintian-overrides?ref_type=heads 5. vimb.metainfo.xml lists the project_license as GPL-3.0-only. This appears to be an error as all the other copyright information I can find in the source code indicates the project license is GPL-3.0+. You should check with upstream and update the file accordingly. Let me know when these small issues are resolved and I will be happy to sponsor the package. -- Soren Stoutner so...@debian.org
signature.asc
Description: This is a digitally signed message part.
