Hello Arnauld,
I created the changes for updating gotest.tools to 3.5.1. I created a fork and
pushed to badrikesh/gotest-3.5.1 branch. Please review the above link:
https://salsa.debian.org/badrikesh/gotest.tools/-/tree/badrikesh/gotest-3.5.1?ref_type=heads
After the update I ran the ratt test as suggested, Here's the result:
```
trixie@debian:~/update-gotest-tools$ ~/go/bin/ratt
gotest.tools_3.5.1-1_amd64.changes
13:49:59 [47/47]
2024/06/11 12:45:02 Loading changes file "gotest.tools_3.5.1-1_amd64.changes"
2024/06/11 12:45:02 - 1 binary packages:
golang-github-gotestyourself-gotest.tools-dev
2024/06/11 12:45:02 Corresponding .debs (will be injected when building):
2024/06/11 12:45:02
golang-github-gotestyourself-gotest.tools-dev_3.5.1-1_all.deb
2024/06/11 12:45:02 Setting -dist=sid (from .changes file)
2024/06/11 12:45:02 Figuring out reverse build dependencies using dose-ceve(1).
This might take a while
2024/06/11 12:45:24 Found 40 reverse build dependencies
2024/06/11 12:45:24 Setting -sbuild_dist=unstable (from .changes file)
2024/06/11 12:45:24 Building package 1 of 40: go-containerregistry
2024/06/11 12:46:25 Building package 2 of 40: crowdsec
2024/06/11 12:49:01 Building package 3 of 40: distrobuilder
2024/06/11 12:50:17 Building package 4 of 40: golang-github-containers-storage
2024/06/11 12:52:46 Building package 5 of 40:
golang-github-openshift-imagebuilder
2024/06/11 12:53:45 Building package 6 of 40:
golang-github-containerd-stargz-snapshotter
2024/06/11 12:55:55 Building package 7 of 40: oci-seccomp-bpf-hook
2024/06/11 12:57:08 Building package 8 of 40:
golang-github-mudler-docker-companion
2024/06/11 12:57:56 Building package 9 of 40:
golang-github-crowdsecurity-go-cs-bouncer
2024/06/11 12:58:54 Building package 10 of 40: golang-github-containers-psgo
2024/06/11 12:59:38 Building package 11 of 40: golang-oras-oras-go
2024/06/11 13:00:32 Building package 12 of 40: libpod
2024/06/11 13:04:12 Building package 13 of 40: golang-github-moby-term
2024/06/11 13:04:38 Building package 14 of 40:
golang-github-checkpoint-restore-checkpointctl
2024/06/11 13:05:29 Building package 15 of 40: gotestsum
2024/06/11 13:06:06 Building package 16 of 40: prometheus
2024/06/11 13:12:51 Building package 17 of 40: golang-github-optiopay-kafka
2024/06/11 13:13:44 Building package 18 of 40: singularity-container
2024/06/11 13:17:38 Building package 19 of 40: golang-github-sigstore-sigstore
2024/06/11 13:18:52 Building package 20 of 40: prometheus-postfix-exporter
2024/06/11 13:19:49 Building package 21 of 40: skopeo
2024/06/11 13:21:18 Building package 22 of 40: gitlab-ci-multi-runner
2024/06/11 13:22:18 building gitlab-ci-multi-runner failed: exit status 2
2024/06/11 13:22:18 Building package 23 of 40: rootlesskit
2024/06/11 13:23:05 Building package 24 of 40: containerd
2024/06/11 13:25:34 Building package 25 of 40: docker.io
2024/06/11 13:31:38 Building package 26 of 40: golang-github-containers-image
2024/06/11 13:33:13 Building package 27 of 40: crowdsec-firewall-bouncer
2024/06/11 13:34:17 Building package 28 of 40: golang-github-containers-buildah
2024/06/11 13:37:06 Building package 29 of 40:
golang-github-samalba-dockerclient
2024/06/11 13:37:59 Building package 30 of 40: golang-k8s-sigs-release-utils
2024/06/11 13:38:47 Building package 31 of 40: crowdsec-custom-bouncer
2024/06/11 13:39:50 Building package 32 of 40: golang-github-crc-org-crc
2024/06/11 13:41:02 Building package 33 of 40: skeema
2024/06/11 13:41:55 Building package 34 of 40:
golang-github-fsouza-go-dockerclient
2024/06/11 13:42:47 Building package 35 of 40: open-vm-tools
2024/06/11 13:45:55 Building package 36 of 40: golang-github-sylabs-sif
2024/06/11 13:46:57 Building package 37 of 40: golang-github-crewjam-saml
2024/06/11 13:47:35 Building package 38 of 40: golang-github-containers-common
2024/06/11 13:49:16 Building package 39 of 40: golang-github-tonistiigi-fsutil
2024/06/11 13:50:03 Building package 40 of 40: tty-share
2024/06/11 13:50:43 1 packages failed the first pass; you can rerun ratt only
for them passing the option -include '^(gitlab-ci-multi-runner)$'
2024/06/11 13:50:43 Build results:
2024/06/11 13:50:43 PASSED: golang-github-containers-psgo
2024/06/11 13:50:43 PASSED: containerd
2024/06/11 13:50:43 PASSED: golang-github-crewjam-saml
2024/06/11 13:50:43 PASSED: golang-github-crc-org-crc
2024/06/11 13:50:43 PASSED: golang-github-containers-common
2024/06/11 13:50:43 PASSED: distrobuilder
2024/06/11 13:50:43 PASSED: golang-oras-oras-go
2024/06/11 13:50:43 PASSED: libpod
2024/06/11 13:50:43 PASSED: golang-github-containers-image
2024/06/11 13:50:43 PASSED: crowdsec-firewall-bouncer
2024/06/11 13:50:43 PASSED: tty-share
2024/06/11 13:50:43 PASSED: golang-github-containerd-stargz-snapshotter
2024/06/11 13:50:43 PASSED: oci-seccomp-bpf-hook
2024/06/11 13:50:43 PASSED: golang-github-optiopay-kafka
2024/06/11 13:50:43 PASSED: golang-github-sigstore-sigstore
2024/06/11 13:50:43 PASSED: rootlesskit
2024/06/11 13:50:43 PASSED: golang-github-fsouza-go-dockerclient
2024/06/11 13:50:43 PASSED: go-containerregistry
2024/06/11 13:50:43 PASSED: crowdsec
2024/06/11 13:50:43 PASSED: golang-github-checkpoint-restore-checkpointctl
2024/06/11 13:50:43 PASSED: golang-github-mudler-docker-companion
2024/06/11 13:50:43 PASSED: golang-github-crowdsecurity-go-cs-bouncer
2024/06/11 13:50:43 PASSED: crowdsec-custom-bouncer
2024/06/11 13:50:43 PASSED: golang-k8s-sigs-release-utils
2024/06/11 13:50:43 PASSED: skeema
2024/06/11 13:50:43 PASSED: open-vm-tools
2024/06/11 13:50:43 PASSED: golang-github-sylabs-sif
2024/06/11 13:50:43 PASSED: golang-github-containers-storage
2024/06/11 13:50:43 PASSED: golang-github-moby-term
2024/06/11 13:50:43 PASSED: singularity-container
2024/06/11 13:50:43 PASSED: docker.io
2024/06/11 13:50:43 PASSED: golang-github-samalba-dockerclient
2024/06/11 13:50:43 PASSED: golang-github-tonistiigi-fsutil
2024/06/11 13:50:43 PASSED: gotestsum
2024/06/11 13:50:43 PASSED: prometheus-postfix-exporter
2024/06/11 13:50:43 PASSED: golang-github-containers-buildah
2024/06/11 13:50:43 PASSED: golang-github-openshift-imagebuilder
2024/06/11 13:50:43 PASSED: prometheus
2024/06/11 13:50:43 PASSED: skopeo
2024/06/11 13:50:43 FAILED: gitlab-ci-multi-runner (see
buildlogs/gitlab-ci-multi-runner_14.10.1-1)
```
Results:
* There's a failure with building gitlab-ci-multi-runner_14.10.1-1 while
building, which is not related to gotest tools
```
gitlab.com/gitlab-org/gitlab-runner/helpers/container/helperimage
gitlab.com/gitlab-org/gitlab-runner/shells/shellstest
gitlab.com/gitlab-org/gitlab-runner/commands/helpers
# gitlab.com/gitlab-org/gitlab-runner/commands/helpers
src/gitlab.com/gitlab-org/gitlab-runner/commands/helpers/file_archiver.go:134:35:
not enough arguments in call to doublestar.Glob
have (string)
want ("io/fs".FS, string, ...doublestar.GlobOption)
```
* I ran the same ratt test with 3.0.3-1 gotest.tools as well
gitlab-ci-multi-runner, still failed. May we should update
gitlab-ci-multi-runner as well
* Other 39 tests passed
* I also tried installing gotest.tools 3.5.1 on the system and ran the
dh_auto_test for docker (removed vendored version of gotest.tools),
dh_auto_test passed, without any error as observed earlier related to:
undefined: is.ErrorIs.
Kindly review the above changes and provide feedback.
Thanks & Regards,
Badrikesh
