---------- Forwarded message --------- From: Bastian Blank <ftpmas...@ftp-master.debian.org> Date: Tue, 9 Apr 2024 at 13:00 Subject: openvpn3-client_21+dfsg-1_amd64.changes REJECTED To: Marc Leeman <marc.lee...@gmail.com>, <ajq...@debian.org>
Hi There are two license inompatibilities: (A)GPL-3 and BSD-4-Clause-UC are incompatible (yes, I saw the comment, but this makes the license either a custom one or possibly a BSD-3-Clause) GPL-2 and AGPL-3 are incompatible AGPL is not suitable for non-network code, so at least debian/* should get something else. Your lintian overrides don't match what ftp-master still expects, see all the errors. The polkit maintainer just asked to reject new packages for shipping legacy polkit pkla files. So please remove the stuff from /var/lib/polkit-1 and convert to the new-style rules. Please drop all autoconf/automake generated and vendored files. We've just seen what this produces as problems. There is vendored code, but also a dependency on the same library (libasio-dev). Some other remarks: - Please use dh_installtmpfiles (rename debian/openvpn3-client.conf to .tmpfiles I think), enabled in debhelper compat 13 - You could use debhelper compat 14 directly and avoid some of the overrides in debian/rules, as it calls dh_installsysusers - Preemptive architecture limits are not the way to go, please remove this list - It contains DSA keys in /etc/openvpn3/awscerts, which a current crypto policy should not really accept - There seems to be two distinct was to start it, openvpn3-autoload.service and openvpn3-session@.service, is this necessary? - /var is not really for user config, but for state. - Is /var/lib/openvpn3 supposed to be in the package or created via systemd-tmpfiles? Currently I see both. === Please feel free to respond to this email if you don't understand why your files were rejected, or if you upload new files which address our concerns. -- g. Marc GPG: 827C FD74 BA46 8152 A041 F3A0 7A6A 4F17 5995 A65B
noname
Description: PGP signature
