On Sun, Jun 23, 2024 at 3:15 PM Phil Wyett <philip.wy...@kathenas.org> wrote: > > On Sun, 2024-06-23 at 14:16 -0300, Leandro Cunha wrote: > > On Sun, Jun 23, 2024 at 7:27 AM Phil Wyett <philip.wy...@kathenas.org> > > wrote: > > > On Sun, 2024-06-23 at 11:37 +0200, Matteo Bini wrote: > > > > Hi Debian developers, > > > > I know that maybe you are busy, but this is the last package that is > > > > needed to close the ITP cdemu report. > > > > > > > > This is the last cdemu component: the rest has all been packaged and now > > > > it's on testing. > > > > > > > > I've tried this package both on stable and on unstable and it works very > > > > well with the other packages. Please, upload it on Debian. > > > > > > > > Thank you very much for the effort and the great work. > > > > > > > > -- > > > > Matteo Bini > > > > > > > > > > Hi Matteo, > > > > > > Preamble... > > > > > > Thanks for taking time to create this package and your contribution to > > > Debian. > > > > > > The below review is for assistance. It is offered to help submitters of > > > packages to Debian mentors improve their packages prior to possible > > > sponsorship into Debian. There is no obligation on behalf of the subitter > > > to > > > make any alterations based upon information provided in the review. > > > > > > Review... > > > > > > 1. Build: Good > > > > > > 2. Lintian: Warnings > > > > > > W: gcdemu: no-manual-page [usr/bin/gcdemu] > > > > > > I: gcdemu: desktop-entry-lacks-keywords-entry > > > [usr/share/applications/gcdemu.desktop] > > > > > > > Package with interface, this Lintian goes into override. Like the case > > of Errands that Jeremy Bicha (GNOME Team) made and I help him > > maintain. > > > > [1] https://cdemu.sourceforge.io/about/gcdemu > > > > Hi Leandro, > > Please keep replies to the relevant bug report or mailing list. We are all > busy > and direct emails just break the conversation. > > In regard to the information supplied. I would be against overriding for lack > of > keywords in a .desktop file. These keywords facilitate searching for other > applications such as software centres. I would encourage a maintainer in the > first instance to discuss with upstream and see if they are willing to add > them. > They will do more good than harm. > > Regards > > Phil >
Ok, I quote about the Lintian tag (no-manual-page) the man page you mentioned. https://salsa.debian.org/gnome-team/errands/-/blob/debian/latest/debian/lintian-overrides?ref_type=heads See the comment he posted. -- Cheers, Leandro Cunha
