Control: tags -1 + moreinfo Dale,
Preamble... Thank you for taking the time to create this package and your contribution to the Debian project. The review below is for assistance. This review is offered to help package submitters to Debian mentors inorder to improve their packages prior to possible sponsorship into Debian. There is no obligation on behalf of the submitter to make any alterations based upon information provided in the review. Review... 1. Build[1]: Good 2. Lintian[2]: Good 3. Licenses (lrc[3]): Good 4. Watch file (uscan --force-download): Good 5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good 6. Reproducible builds (reporotest)[3]: Issue [100%] Built target cli.t make -f t/CMakeFiles/check.dir/build.make t/CMakeFiles/check.dir/depend make[4]: Entering directory '/tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux- gnu' cd /tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux- gnu && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /tmp/reprotest.ZWXuMc/const_build_path/const_build_path /tmp/reprotest.ZWXuMc/const_build_path/const_build_path/t /tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux-gnu /tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux- gnu/t /tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64- linux-gnu/t/CMakeFiles/check.dir/DependInfo.cmake "--color=" make[4]: Leaving directory '/tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux- gnu' make -f t/CMakeFiles/check.dir/build.make t/CMakeFiles/check.dir/build make[4]: Entering directory '/tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux- gnu' cd /tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux- gnu/t && prove /tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj- x86_64-linux-gnu/t /tmp/reprotest.ZWXuMc/const_build_path/const_build_path/t /tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux- gnu/t/base64.t .. ok /tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux- gnu/t/cli.t ..... ok /tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux- gnu/t/ogg.t ..... ok /tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux- gnu/t/opus.t .... ok /tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux- gnu/t/system.t .. # fail: opening a device as a partial file should fail /tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux- gnu/t/system.t .. Failed 1/4 subtests /tmp/reprotest.ZWXuMc/const_build_path/const_build_path/t/opustags.t ..................... ok Test Summary Report ------------------- /tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux- gnu/t/system.t (Wstat: 0 Tests: 4 Failed: 1) Failed test: 1 Files=6, Tests=87, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.13 cusr 0.04 csys = 0.19 CPU) Result: FAIL make[4]: *** [t/CMakeFiles/check.dir/build.make:79: t/CMakeFiles/check] Error 1 make[4]: Leaving directory '/tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux- gnu' make[3]: *** [CMakeFiles/Makefile2:324: t/CMakeFiles/check.dir/all] Error 2 make[3]: Leaving directory '/tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux- gnu' make[2]: *** [CMakeFiles/Makefile2:331: t/CMakeFiles/check.dir/rule] Error 2 make[2]: Leaving directory '/tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux- gnu' make[1]: *** [Makefile:276: check] Error 2 make[1]: Leaving directory '/tmp/reprotest.ZWXuMc/const_build_path/const_build_path/obj-x86_64-linux- gnu' dh_auto_test: error: cd obj-x86_64-linux-gnu && make -j6 check ARGS\+=-- verbose ARGS\+=-j6 returned exit code 2 make: *** [debian/rules:9: binary] Error 255 dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2 Traceback (most recent call last): File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 862, in run return 0 if check_func(*check_args) else 1 ^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 410, in check_auto dist_x0 = proc.send(("control", var_x0)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 339, in corun_builds bctx.run_build(testbed, build, os.environ, artifact_pattern, testbed_build_pre, no_clean_on_error) File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 218, in run_build testbed.check_exec2(build_argv, File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 63, in check_exec2 self.bomb('"%s" failed with status %i' % (' '.join(argv), code), File "/usr/lib/python3/dist-packages/reprotest/__init__.py", line 70, in bomb raise _type(m) reprotest.lib.adtlog.AutopkgtestError: "su -p -s /bin/sh root -c set -e; export PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin; run_build() { mkdir -p /tmp/reprotest.ZWXuMc/build-control-aux && \ mv /tmp/reprotest.ZWXuMc/build-control/ /tmp/reprotest.ZWXuMc/const_build_path && \ SETARCH_ARCH=$(uname -m) && \ SETARCH_OPTS="$SETARCH_OPTS -R" && \ CPU_MAX=$(nproc) && \ CPU_MIN=$({ echo $CPU_MAX; echo 6; } | sort -n | head -n1) && \ CPU_NUM=$CPU_MIN && \ export CPU_LIST="$(echo $(shuf -i0-$((CPU_MAX - 1)) -n$CPU_NUM) | tr ' ' ,)" && \ umask 0022 && \ export REPROTEST_BUILD_PATH=/tmp/reprotest.ZWXuMc/const_build_path/ && \ export REPROTEST_UMASK=$(umask) && \ taskset -a -c $CPU_LIST \ setarch $SETARCH_ARCH $SETARCH_OPTS \ sh -ec 'cd "$REPROTEST_BUILD_PATH"; unset REPROTEST_BUILD_PATH; umask "$REPROTEST_UMASK"; unset REPROTEST_UMASK; dpkg-source -x "opustags_1.10.1- 1.dsc" "$(basename "$PWD")" && cd "$(basename "$PWD")" && dpkg-buildpackage - -no-sign -b' } cleanup() { __c=0; \ mv /tmp/reprotest.ZWXuMc/const_build_path /tmp/reprotest.ZWXuMc/build- control/ || __c=$?; \ rm -rf /tmp/reprotest.ZWXuMc/build-control-aux || __c=$?; \ exit $__c } trap '( cleanup )' HUP INT QUIT ABRT TERM PIPE # FIXME doesn't quite work reliably yet if ( run_build ); then ( cleanup ); else __x=$?; # save the exit code of run_build if ( ! false ); then if ( cleanup ); then :; else echo >&2 "cleanup failed with exit code $?"; fi; fi exit $__x fi" failed with status 2 7. Install (No previous installs): Good 8. Upgrade (Over previous installs if any): Good Summary... I believe opustags is not yet ready for sponsorship/upload. Could the contributor rectify one of more of the rasied issues. Once updated to your satisfaction and a new upload done, please remove the 'moreinfo' on the Request For Sponsorship (RFS) bug report. Regards Phil [1] Using: * pbuilder - https://wiki.ubuntu.com/PbuilderHowto. * https://wiki.debian.org/PbuilderTricks and * sbuild - https://wiki.debian.org/sbuild. [2] Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes, *.buildinfo). Each can throw up different, so be thorough. [3] 'lrc' from 'licenserecon' is located in Debian testing and newer. [4] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method -- "I play the game for the game’s own sake" Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans -- Internet Relay Chat (IRC): kathenas Website: https://kathenas.org Instagram: https://instagram.com/kathenasorg/ Buy Me A Coffee: https://buymeacoffee.com/kathenasorg --
signature.asc
Description: This is a digitally signed message part