Hi, On 2024-07-22 03:05, Boyuan Yang wrote: >> https://mentors.debian.net/debian/pool/main/m/msc-generator/msc-generator_8.6.2-1.dsc > > I think all changes look okay except for adding the usage of dpkg-vendor and > exporting a specific environment variable only on Debian in debian/rules.
I'll try to explain. This env var: +VENDOR ?= $(shell dpkg-vendor --query vendor) ... +ifneq ($(VENDOR),Debian) +export PNGDIFF_LUMA_DIFF = 10 +endif only affects *tests*: the program `msc-gen` generates pixmaps and during tests we verify if some known input is rendered to the same PNG as some known canonical one. It becomes tricky exactly with downstream if a library like libcairo/libpango has a somewhat different version not otherwise affecting actual usability of the tool but causing one-two pixel differences when generating the test PNGs, failing package building and thus finally blocking a new package version to be accepted [1]. The upstream CI works on Debian and we fully can control what is expected on Debian, so in this sense the env var setting only makes Debian testing more strictly adhering to upstream. In short, `dpkg-vendor` here only controls precision of PNG-generating tests and has no effect on the binary tool itself whatsoever. I can remove the distinction wrt. other ditros but would prefer to keep it to be in sync with upstream build results. Thanks for taking your time & BR, Gábor [1] https://bugs.launchpad.net/ubuntu/+source/msc-generator/+bug/2061755
