On 2024-08-13 10:17:12, Georg Faerber wrote:
> Control: X-Debbugs-CC: anar...@debian.org
>
> Hi all,
>
> Thanks for this bookworm-pu!
>
> While debugging some systems today, I wondered why, at least on my
> systems, the 'apt_package_cache_timestamp_seconds' metric is missing.
>
> Looking at the attached debdiff [1] and the commit [2], it seems to me
> that, while the relevant code, _write_cache_timestamps(registry), was
> added, it's not called via _main() in the end, which is in contrast to
> the changes made upstream [3].
>
> I would like to see this fixed in a follow-up bookworm-pu. Please let me
> know if support in this regard is helpful.
Not sure how to proceed here, but here's a debdiff:
diff -Nru prometheus-node-exporter-collectors-0.0~git20230203.6f710f8/debian/changelog prometheus-node-exporter-collectors-0.0~git20230203.6f710f8/debian/changelog
--- prometheus-node-exporter-collectors-0.0~git20230203.6f710f8/debian/changelog 2023-10-31 13:57:52.000000000 -0400
+++ prometheus-node-exporter-collectors-0.0~git20230203.6f710f8/debian/changelog 2024-08-21 14:46:21.000000000 -0400
@@ -1,3 +1,10 @@
+prometheus-node-exporter-collectors (0.0~git20230203.6f710f8-1+deb12u2) bookworm; urgency=medium
+
+ * Team upload
+ * Add missing `apt_package_cache_timestamp_seconds` metrics ommitted from previous upload.
+
+ -- Antoine Beaupré <anar...@debian.org> Wed, 21 Aug 2024 14:46:21 -0400
+
prometheus-node-exporter-collectors (0.0~git20230203.6f710f8-1+deb12u1) bookworm; urgency=medium
* Team upload
diff -Nru prometheus-node-exporter-collectors-0.0~git20230203.6f710f8/debian/patches/0001-use-a-better-heuristic-for-the-apt-update-last-run-t.patch prometheus-node-exporter-collectors-0.0~git20230203.6f710f8/debian/patches/0001-use-a-better-heuristic-for-the-apt-update-last-run-t.patch
--- prometheus-node-exporter-collectors-0.0~git20230203.6f710f8/debian/patches/0001-use-a-better-heuristic-for-the-apt-update-last-run-t.patch 2023-10-31 13:57:52.000000000 -0400
+++ prometheus-node-exporter-collectors-0.0~git20230203.6f710f8/debian/patches/0001-use-a-better-heuristic-for-the-apt-update-last-run-t.patch 2024-08-21 14:42:17.000000000 -0400
@@ -58,3 +58,11 @@
)
except OSError:
pass
+@@ -104,6 +113,7 @@ def _main():
+ _write_pending_upgrades(cache)
+ _write_held_upgrades(cache)
+ _write_autoremove_pending(cache)
++ _write_cache_timestamps()
+ _write_reboot_required()
+
+
BTW, I need to implement a pile more things onto apt_info.py, and will
probably not be able to deploy those through debian stable, as it's a
bunch of new features, see:
https://gitlab.torproject.org/tpo/tpa/team/-/issues/41712
So I'm not sure I'll be deploying even *this* patch myself. If the
release team agrees on the patch, however, I will certainly test it on
the fleet first.
a.
