On Tue, 2024-08-20 at 17:16 +0200, Aurélien COUDERC wrote:
> Le mardi 20 août 2024, 12:37:14 CEST Rongrong a écrit :
> > Dear Maintainer,
>
> Dear Rong,
Dear Aurélien,
> […]
>
> thanks for the analysis, I didn’t want to dive into it myself but that’s
> appreciated !
Thanks for trying my suggestion and getting back to me so swiftly.
> > Backporting a tiny commit [1] from KF6 may fix the issue. Or ignore
> > this bug report if the migration to KDE Plasma 6 soon arrives. :)
>
> This doesn’t seem to be enough. Please find a screenshot in a recently
> installed sid VM.
> Dolphin’s icon in Plasma is still black,
I didn't experiment as the ifdef in that commit gave me too much
confidence...sorry for that!
Unfortunately, I haven't found a workaround to make icons in Plasma
seem right...
> and the colors of folders in gwenview changed from black to white, I don’t
> see that as particularly improving the situation. :)
That being said, I did manage to fix the icons in Dolphin, Gwenview,
etc.
After some attempts, I've figured out that a later commit [1], along
with the commit [2] I'd mentioned, is needed.
[1]: "Flip logic when to use Accent/HighlightedText"
(aa89a2ce9d873860f5a858edcd244dfb23241177)
[2]: "Expose accent color in KIConColors"
(e6fa360255e3a5e9b449be7875904f851601f29e)
There is also a more straightforward (single-line) workaround, without
requiring backporting the mentioned commits above:
diff --git a/src/kiconcolors.cpp.orig b/src/kiconcolors.cpp
index 1a05abf..e78cb9c 100644
--- a/src/kiconcolors.cpp.orig
+++ b/src/kiconcolors.cpp
@@ -23,6 +23,7 @@ static QString STYLESHEET_TEMPLATE()
.ColorScheme-ActiveText{ color:%8; }\
.ColorScheme-Complement{ color:%9; }\
.ColorScheme-Contrast{ color:%10; }\
+.ColorScheme-Accent{ color:%3; }\
");
/* clang-format on */
}
The patch actually partially fixes icons in Plasma - folders **with**
preview of their content look fine now, though the icons of Dolphin and
folders **without** preview are still broken.
> Happy hacking,
> --
> Aurélien
Thanks,
Rong
