On 27/08/2024 at 22:54, Holger Wansing wrote:
Am 27. August 2024 21:47:14 MESZ schrieb Pascal Hambourg 
<pas...@plouf.fr.eu.org>:

<https://people.debian.org/~holgerw/d-i__new-limits_and_fix-envelope-calculation/attempt_2/10G-disk__1G-RAM/use-entire-disk__separate-home-var-tmp.png>

/home is smaller than the minimum size defined by the recipe. It
should not happen. I cannot even figure out how such a result is
possible. The multi recipe minimum disk size is 11GB so it should
not have been available with a 10.7GB disk. I need to investigate.

Good catch!
I also noticed some inconsistency here, but I did not mention it,
considering it being a corner case:

when entering the menu (use entire disk -> <disk identifier> )
the first time, the "separate home+tmp+var" choice was not provided,
but in my tests I restarted the partitioning step multiple times, and
so, when choosing "guided partioning" -> "use entire disk" -> <disk-
identifier> once more again, it was surprisingly there!

I suspect this is caused by the "reuse" feature. It allows to reuse existing partitions of the same type (biosgrub, efi, swap) as partitions defined in the recipe with the "reusemethod" flag instead of creating them when partitioning using the largest free space. But it seems it is used when checking the minimum size regardless of whether using the largest free space or a whole disk (same code path). I need to figure out how to disable it when using whole disks.

By the way, the reuse feature does not check if an existing partition size is greater than or equal to the minimum size defined in the recipe. IMO it should. Also existing swap partitions should not be reused, or at least not forcefully formated, because it may belong to another system.

This was my initial intent. I removed the lvmok flag (and /boot) from
the small_disk recipe and expected it to be ignored when using LVM.
Looking at partman-auto-lvm code more closely, it seems that the lvmok
flag check happens only after calling choose_recipe. So I guess the
check should be moved into choose_recipe (in partman-auto).

Ok. I would propose to move such change into a separate discussion/
bug report. Putting onto my to-do list.

Fine, but what do we do with the small_disk recipe now ?

Reply via email to