On 2024-09-07, at 22:50:28 -0700, Xiyue Deng wrote:
> Package: sponsorship-requests
> Severity: normal
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "emacs-buttercup":
> 
>  * Package name     : emacs-buttercup
>    Version          : 1.36-1
>    Upstream contact : Jorgen Schaefer <cont...@jorgenschaefer.de>
>  * URL              : https://github.com/jorgenschaefer/emacs-buttercup/
>  * License          : GPL-3+, GFDL-1.2+ or CC-BY-SA-3.0
>  * Vcs              : https://salsa.debian.org/emacsen-team/emacs-buttercup
>    Section          : lisp
> 
> The source builds the following binary packages:
> 
>   elpa-buttercup - behaviour-driven testing for Emacs Lisp packages
> 
> To access further information about this package, please visit the following 
> URL:
> 
>   https://mentors.debian.net/package/emacs-buttercup/
> 
> Alternatively, you can download the package with 'dget' using this command:
> 
>   dget -x 
> https://mentors.debian.net/debian/pool/main/e/emacs-buttercup/emacs-buttercup_1.36-1.dsc
> 
> Changes since the last upload:
> 
>  emacs-buttercup (1.36-1) unstable; urgency=medium
>  .
>    * New upstream release

This doesn't work:

>    * Drop override_dh_auto_test to use default dh_elpa_test

dh_elpa_test only runs a package's test-suite if the package build-
depends on elpa-buttercup.  Since this is the source package for
elpa-buttercup, that is not the case, and dh_elpa_test exits without
doing anything.

Because we can't use dh_elpa_test, we also can't do this:

>    * Drop setting EMACS_INHIBIT_AUTOMATIC_NATIVE_COMPILATION now it is the
>      default

As it happens, the existing dh_auto_test override doesn't actually work
any more: the upstream code has changed sufficiently that it just loads
tests/test-buttercup.el without actually running any tests.  However,
the default make target, "all", has no rules and one dependency on a
target that _does_ run the full test-suite, so dh_auto_build has been
running it instead by accident.  My suggestion, therefore, is to skip
dh_auto_build, remove the dh_auto_test override, and let dh_auto_test
just run `make check`.  I have pushed a branch to Salsa that implements
this and makes a few other changes:

    
https://salsa.debian.org/emacsen-team/emacs-buttercup/-/tree/dh-auto-test-fixes?ref_type=heads

Seem reasonable?

>    * Update d/watch with filenamemangle for generating sane package name
>    * Update Standards-Version to 4.7.0; no change needed

J.

Attachment: signature.asc
Description: PGP signature

Reply via email to