Package: release.debian.org Severity: normal Tags: bookworm X-Debbugs-Cc: node-glo...@packages.debian.org Control: affects -1 + src:node-globby User: release.debian....@packages.debian.org Usertags: pu
[ Reason ] Package FTBFS in stable [ Tests ] Builds fine and has non-trivial autopkgtests. [ Risks ] Small. An internal typescript declaration needed to be fixed. [ Checklist ] [x] *all* changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in (old)stable [x] the issue is verified as fixed in unstable [ Changes ] Two classes that inherit from Dirent fail to implement its interface because of a missing property (parentPath). This is somewhat a false problem, because that property is deprecated, but typescript in bookworm doesn't know about that, and adding that property is the fix.
diff -Nru node-globby-13.1.3+~cs16.25.40/debian/changelog node-globby-13.1.3+~cs16.25.40/debian/changelog --- node-globby-13.1.3+~cs16.25.40/debian/changelog 2022-12-17 19:15:55.000000000 +0100 +++ node-globby-13.1.3+~cs16.25.40/debian/changelog 2024-09-08 22:12:56.000000000 +0200 @@ -1,3 +1,11 @@ +node-globby (13.1.3+~cs16.25.40-1+deb12u1) bookworm; urgency=medium + + * Team upload + * Upload to bookworm + * Backport patch to fix build with node 18. Closes: #1072599. + + -- Jérémy Lal <kapo...@melix.org> Sun, 08 Sep 2024 22:12:56 +0200 + node-globby (13.1.3+~cs16.25.40-1) unstable; urgency=medium * Team upload diff -Nru node-globby-13.1.3+~cs16.25.40/debian/gbp.conf node-globby-13.1.3+~cs16.25.40/debian/gbp.conf --- node-globby-13.1.3+~cs16.25.40/debian/gbp.conf 2020-10-19 09:29:15.000000000 +0200 +++ node-globby-13.1.3+~cs16.25.40/debian/gbp.conf 2024-09-08 22:11:00.000000000 +0200 @@ -1,4 +1,5 @@ [DEFAULT] +debian-branch=debian/bookworm pristine-tar=True component=['dir-glob', 'fast-glob', 'fastq', 'merge2', 'reusify', 'run-parallel', 'nodelib-fsscandir', 'nodelib-fsstat', 'nodelib-fswalk', 'nodelib-fs-macchiato'] diff -Nru node-globby-13.1.3+~cs16.25.40/debian/patches/series node-globby-13.1.3+~cs16.25.40/debian/patches/series --- node-globby-13.1.3+~cs16.25.40/debian/patches/series 2022-12-17 19:14:34.000000000 +0100 +++ node-globby-13.1.3+~cs16.25.40/debian/patches/series 2024-09-08 22:09:40.000000000 +0200 @@ -1,2 +1,3 @@ export-commonjs-files.patch replace-ava-by-tape.patch +update-compat-with-node-18.patch diff -Nru node-globby-13.1.3+~cs16.25.40/debian/patches/update-compat-with-node-18.patch node-globby-13.1.3+~cs16.25.40/debian/patches/update-compat-with-node-18.patch --- node-globby-13.1.3+~cs16.25.40/debian/patches/update-compat-with-node-18.patch 1970-01-01 01:00:00.000000000 +0100 +++ node-globby-13.1.3+~cs16.25.40/debian/patches/update-compat-with-node-18.patch 2024-09-08 22:10:51.000000000 +0200 @@ -0,0 +1,35 @@ +Description: fix TS decalrations with Node.js >= 18 +Author: Yadd <y...@debian.org> +Bug-Debian: https://bugs.debian.org/1058547 +Forwarded: not-needed +Last-Update: 2024-03-21 + +--- a/fast-glob/src/utils/fs.ts ++++ b/fast-glob/src/utils/fs.ts +@@ -10,6 +10,8 @@ + public isFile: fs.Stats['isFile']; + public isSocket: fs.Stats['isSocket']; + public isSymbolicLink: fs.Stats['isSymbolicLink']; ++ public path: ''; ++ public parentPath: ''; + + constructor(public name: string, stats: fs.Stats) { + this.isBlockDevice = stats.isBlockDevice.bind(stats); +@@ -19,6 +21,8 @@ + this.isFile = stats.isFile.bind(stats); + this.isSocket = stats.isSocket.bind(stats); + this.isSymbolicLink = stats.isSymbolicLink.bind(stats); ++ this.path = ''; ++ this.parentPath = ''; + } + } + +--- a/nodelib-fs-macchiato/out/dirent.d.ts ++++ b/nodelib-fs-macchiato/out/dirent.d.ts +@@ -12,4 +12,6 @@ + isSymbolicLink(): boolean; + isFIFO(): boolean; + isSocket(): boolean; ++ path: string; ++ parentPath: string; + }