Source: python-trezor
Version: 0.12.4-3.1
Severity: normal
User: [email protected]
Usertags: python3.13

This package failed build from source when test-built against a version of
python3-defaults that includes 3.13 as a supported version.

To reproduce this issue, build against python3-defaults (python3-all-dev etc.)
from Debian experimental.

What's new in Python 3.13:
https://docs.python.org/3.13/whatsnew/3.13.html
xdrlib was removed in 3.13.

I see that upstream, this import is gone in newer releases, but I
haven't gone chasing down when this was removed.

Log snippet:

   dh_auto_test -O--buildsystem=pybuild
I: pybuild base:311: cd /<<PKGBUILDDIR>>/.pybuild/cpython3_3.13_trezor/build; 
python3.13 -m pytest tests
============================= test session starts ==============================
platform linux -- Python 3.13.0rc2, pytest-8.3.3, pluggy-1.5.0
rootdir: /<<PKGBUILDDIR>>
plugins: typeguard-4.3.0
collected 39 items / 1 error

==================================== ERRORS ====================================
__ ERROR collecting .pybuild/cpython3_3.13_trezor/build/tests/test_stellar.py __
ImportError while importing test module 
'/<<PKGBUILDDIR>>/.pybuild/cpython3_3.13_trezor/build/tests/test_stellar.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.13/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_stellar.py:19: in <module>
    from trezorlib import messages, stellar
trezorlib/stellar.py:19: in <module>
    import xdrlib
E   ModuleNotFoundError: No module named 'xdrlib'
=========================== short test summary info ============================
ERROR tests/test_stellar.py
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.55s ===============================
E: pybuild pybuild:389: test: plugin distutils failed with: exit code=2: cd 
/<<PKGBUILDDIR>>/.pybuild/cpython3_3.13_trezor/build; python3.13 -m pytest tests
I: pybuild base:311: cd /<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_trezor/build; 
python3.12 -m pytest tests
============================= test session starts ==============================
platform linux -- Python 3.12.6, pytest-8.3.3, pluggy-1.5.0
rootdir: /<<PKGBUILDDIR>>
plugins: typeguard-4.3.0
collected 58 items

tests/test_btc.py ..                                                     [  3%]
tests/test_cosi.py ...........                                           [ 22%]
tests/test_nem.py .                                                      [ 24%]
tests/test_protobuf_encoding.py ..........                               [ 41%]
tests/test_protobuf_misc.py ...........                                  [ 60%]
tests/test_stellar.py ...................                                [ 93%]
tests/test_tools.py .                                                    [ 94%]
tests/test_transport.py ...                                              [100%]

=============================== warnings summary ===============================
trezorlib/stellar.py:19
  /<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_trezor/build/trezorlib/stellar.py:19: 
DeprecationWarning: 'xdrlib' is deprecated and slated for removal in Python 3.13
    import xdrlib

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================== 58 passed, 1 warning in 0.68s =========================
dh_auto_test: error: pybuild --test --test-pytest -i python{version} -p "3.13 
3.12" returned exit code 13
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------
Build finished at 2024-09-19T09:02:53Z


If required, the full build log is available here (for the next 30 days):
https://debusine.debian.net/artifact/789902/

This bug has been filed at "normal" severity, as we haven't started the
transition to add 3.13 as a supported version, yet. This will be raised to RC
as soon as that happens, hopefully well before trixie.

Thanks,

Stefano

Reply via email to