Control: -1 fixed runit-services/0.7.0
Hi Andrew, On Sun, 27 Oct 2024 08:05:46 +0000 Andrew Bower <and...@bower.uk> wrote: > > This affects users with ifupdown scripts, network-manager and probably > anyone who doesn't simply want dhcp on any physical interfaces > present. > > This is fixed in 0.7.0 and later by disabling the dhclient runscript > by default. Ideally this fix would be backported to bookworm to avoid > any new installations failing badly. > [...] > The new installation fix is a backport of this commit: > > https://salsa.debian.org/debian/runit-services/-/commit/caf085228bbaa351749504fafd39609e2f5ec48b This looks bad enough so I'm going to ask release-team approval for a stable update, they have the final call on this > > I am not sure how to fix for upgrades, but as it was broken by my > upgrade it is presumably possible to fix in an upgrade, too. I suggest > the runscript exit and down the service if the INTERFACES environment > variable is empty - that is essentially an unconfigured state. > > Really I think you only want this runscript if you have zero network > configuration capability, not even the underrated ifupdown, which is > perfectly capable of organising DHCP out of the box! Somehow I agree but according to dhclient(8) the interface parameter in command line is optional, and in fact it works like that in my system. The service log is full of messages " No DHCPOFFERS received." for other interfaces, so yes, I'm very lazy and my service can be considered not properly configured, but other than that, it works fine. > > Would there be any interest in a patch to fix upgrades or is it highly > unlikely that any fix would be accepted into bookworm? I don't know, except that a larger diff is less likely to be accepted; in any case the fix needs to land to unstable first. I don't think there is a reliable way to tell if the service is enabled due to a sysadmin decision or just because that was the default. If I disable it unconditionally or put the service down with a check on empty INTERFACES I can break people setups, so I don't want to do that. Only things that comes to my mind is to write an entry in the NEWS file explaining that there are bad interactions with other ways to configure the network and that it should be disabled unless it was intentionally enabled. The message will be displayed on upgrade when apt-listchanges is installed. Lorenzo > > Thank you for runit-services! > > > From caf085228bbaa351749504fafd39609e2f5ec48b Mon Sep 17 00:00:00 2001 > From: Lorenzo Puliti <plore...@disroot.org> > Date: Fri, 22 Sep 2023 18:20:54 +0200 > Subject: [PATCH] dhclient: ship as disabled by default > > it appears that dhclient is started automatically by some network > software; other inits also do not appear to have a services defined > for dhclient. So shipping as disabled by default is the least > surprise approach and also avoid duplicate instances. > This change is applied to new install of this package, on > upgrade the old setting is retained. > --- > debian/runit-services.runit | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/debian/runit-services.runit b/debian/runit-services.runit > index fa8e823..dbf97a2 100644 > --- a/debian/runit-services.runit > +++ b/debian/runit-services.runit
