Source: python-aiovlc
Version: 0.4.2-2
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: timestamps
X-Debbugs-Cc: [email protected]
Hi,
Whilst working on the Reproducible Builds effort [0], we noticed that
python-aiovlc could not be built reproducibly.
This is due to the coverage.xml file embedding a timestamp, but also
because the snippet in debian/rules that's meant to remove this file
is not quite right:
override_dh_fixperms:
dh_fixperms
- rm -f
$(CURDIR)/debian/python3-aiovlc/usr/lib/python3/dist-packages/coverage.xml
+ rm -f
$(CURDIR)/debian/python3-aiovlc/usr/lib/python3*/dist-packages/coverage.xml
However, I think this could be improved and perhaps made a little more
future-proof by removing the entire dh_fixperms override and replacing
it with:
export PYBUILD_TEST_ARGS= -v tests
+export PYBUILD_AFTER_TEST = rm -rfv {build_dir}/coverage.xml
This patch is attached.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` [email protected] / chris-lamb.co.uk
`-
--- a/debian/rules 2024-11-27 10:13:56.306783380 +0000
--- b/debian/rules 2024-11-27 10:26:22.338629298 +0000
@@ -4,10 +4,7 @@
include /usr/share/openstack-pkg-tools/pkgos.make
export PYBUILD_TEST_ARGS= -v tests
+export PYBUILD_AFTER_TEST = rm -rfv {build_dir}/coverage.xml
%:
dh $@ --buildsystem=pybuild --with python3
-
-override_dh_fixperms:
- dh_fixperms
- rm -f
$(CURDIR)/debian/python3-aiovlc/usr/lib/python3/dist-packages/coverage.xml
