Hi Am 03.12.24 um 14:44 schrieb Theodore Y. Ts'o:
A) Change fsarchiver to drop specifying the "-r" option to mke2fs. This
would solve the problem, but it would mean that fsarchiver would not be
able to accurate backup and restore file systems from 3 decades ago.
B) Revert e2fsprogs's change to address bug 1086603 and not worry about
leaving an exposed, sharp edge to careless users.
C) Change e2fsprogs to silently accept mke2fs -r 1, but to fail on -r 0.
This solves the Debian continuous integration failure, thus
unblocking e2fsprogs, but would cause fsarchiver to fail to be able
to restore file systems dating from 3 decades ago.
D) Change fsarchiver to retry with -E revision=N, if -r N fails. This
works, but adds potential complexity all just to handle file systems
dating from 3 decades ago.
Personally I would prefer B, all the other options don't sound really appealing.
Maybe as a compromise, you could go with B) but print a warning to stdout/stderr if -r 0 is used, explaining why this might be bad idea.
This would have the benefit of not breaking existing software/scripts and at the same time helping users to not fall into this trap.
The fsarchiver autopkgtest uses allow-stderr, so a message on stderr would not make the autopkgtest fail.
Michael
OpenPGP_signature.asc
Description: OpenPGP digital signature
