Bug#1090358: sbuild: please pre-set config variables with their defaults

[Johannes Schauer Marin Rodrigues]

Hi,

Quoting Chris Hofstaedtler (2024-12-18 09:12:08)
> It it was just about BUILD_DIR, maybe we can get away with ignoring vars that
> have IGNORE_DEFAULT => 1?

that would overload the meaning of a setting that is intended for a completely
different purpose. How about this instead:


--- a/lib/Sbuild/Conf.pm
+++ b/lib/Sbuild/Conf.pm
@@ -904,7 +904,16 @@ $unshare_mmdebstrap_extra_args = [
            TYPE => 'STRING',
            VARNAME => 'build_dir',
            GROUP => 'Core options',
-           DEFAULT => cwd(),
+           DEFAULT => undef,
+           GET => sub {
+               my $conf = shift;
+               my $entry = shift;
+               my $retval = $conf->_get($entry->{'NAME'});
+               if (!defined($retval)) {
+                   $retval = cwd();
+               }
+               return $retval;
+           },
            IGNORE_DEFAULT => 1, # Don't dump class to config
            EXAMPLE => '$build_dir = \'/home/pete/build\';',
            CHECK => $validate_directory,


Thanks!

cheers, josch

signature.asc
Description: signature