Bug#1089440: sreview: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 21:41:59 +0100 Niels Thykier <ni...@thykier.net> wrote:

Source: sreview
Version: 0.10.0-1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
sreview failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

Hi

Please see attached as a patch.



Best regards,
Niels


diff -u sreview-0.10.0/debian/changelog sreview-0.10.0/debian/changelog
--- sreview-0.10.0/debian/changelog
+++ sreview-0.10.0/debian/changelog
@@ -1,3 +1,12 @@
+sreview (0.10.0-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove need for root when building the package.
+    (Closes: #1089440)
+  * Tweak debian/rules to use more modern hook targets.
+
+ -- Niels Thykier <ni...@thykier.net>  Wed, 01 Jan 2025 10:32:15 +0000
+
 sreview (0.10.0-1) unstable; urgency=medium
 
   * New upstream release, with various fixes.
diff -u sreview-0.10.0/debian/control sreview-0.10.0/debian/control
--- sreview-0.10.0/debian/control
+++ sreview-0.10.0/debian/control
@@ -1,6 +1,7 @@
 Source: sreview
 Section: video
 Priority: optional
+Rules-Requires-Root: no
 Standards-Version: 4.1.1
 Maintainer: Wouter Verhelst <wou...@debian.org>
 Vcs-Browser: https://salsa.debian.org/wouter/sreview
diff -u sreview-0.10.0/debian/rules sreview-0.10.0/debian/rules
--- sreview-0.10.0/debian/rules
+++ sreview-0.10.0/debian/rules
@@ -3,9 +3,11 @@
 %:
        dh $@ --with apache2
 
-override_dh_install:
+execute_before_dh_install:
        chmod +x debian/sreview-master.install debian/sreview-master.dbc
-       dh_install
+       # Apply sane minimum mode. This might be fixed in dh_auto_install
+       # as of compat 14 (making this command redundant at that time).
+       chmod -R u+rwX -R debian/tmp
 
 override_dh_installsystemd:
        dh_installsystemd -psreview-master --name=sreview-dispatch

I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.

OpenPGP_signature.asc
Description: OpenPGP digital signature