Bug#1089397: netmaze: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 20:53:52 +0100 Niels Thykier <ni...@thykier.net> wrote:

Source: netmaze
Version: 0.81+jpg0.82-18
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
netmaze failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

Hi

Please see attached as a patch.



Note to self: Maintainer is on low NMU threshold, so delay can be skipped.

Best regards,
Niels


diff -u netmaze-0.81+jpg0.82/debian/changelog 
netmaze-0.81+jpg0.82/debian/changelog
--- netmaze-0.81+jpg0.82/debian/changelog
+++ netmaze-0.81+jpg0.82/debian/changelog
@@ -1,3 +1,11 @@
+netmaze (0.81+jpg0.82-18.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove need for root when building the package.
+    (Closes: #1089397)
+
+ -- Niels Thykier <ni...@thykier.net>  Wed, 01 Jan 2025 10:51:30 +0000
+
 netmaze (0.81+jpg0.82-18) unstable; urgency=medium
 
   * Various fixes for newer gcc.  Closes: #1075312.
diff -u netmaze-0.81+jpg0.82/debian/control netmaze-0.81+jpg0.82/debian/control
--- netmaze-0.81+jpg0.82/debian/control
+++ netmaze-0.81+jpg0.82/debian/control
@@ -2,6 +2,7 @@
 Maintainer: John Goerzen <jgoer...@complete.org>
 Section: games
 Priority: optional
+Rules-Requires-Root: no
 Standards-Version: 3.5.2
 Build-Depends: sharutils, tix-dev, libx11-dev, libxext-dev, libxt-dev, 
x11proto-core-dev, x11-utils, x11-xserver-utils, x11-session-utils, 
xfonts-utils, xutils-dev, debhelper
 
diff -u netmaze-0.81+jpg0.82/debian/rules netmaze-0.81+jpg0.82/debian/rules
--- netmaze-0.81+jpg0.82/debian/rules
+++ netmaze-0.81+jpg0.82/debian/rules
@@ -44,9 +44,9 @@
                debian/tmp/usr/share/doc/$(PACKAGENAME) debian/tmp/usr/lib/menu 
\
                $(LIBDIR)
 # Netmaze goes into bin, everything else to the lib dir.
-       install -o root -g root -m 0755 $(BINARIES) debian/tmp/usr/games
-       install -o root -g root -m 0755 xnetserv debian/tmp/usr/games
-       install -o root -g root -m 0755 $(AUXBINARIES) $(LIBDIR)/
+       install -m 0755 $(BINARIES) debian/tmp/usr/games
+       install -m 0755 xnetserv debian/tmp/usr/games
+       install -m 0755 $(AUXBINARIES) $(LIBDIR)/
        cp -r mazes lib *.tcl $(LIBDIR)
        chmod 0755 $(LIBDIR)/{mazes,lib,*.tcl}
        uudecode nmlogo.gif.uue
@@ -59,16 +59,15 @@
        cp debian/menu debian/tmp/usr/lib/menu/netmaze
        dpkg-shlibdeps debian/tmp/usr/games/netmaze \
                $(LIBDIR)/{netserv,betterbot,follower,dummy}
-       install -o root -g root -m 755 debian/prerm debian/tmp/DEBIAN/
-       install -o root -g root -m 755 debian/postinst debian/tmp/DEBIAN/
-       install -o root -g root -m 755 debian/postrm debian/tmp/DEBIAN/
+       install -m 755 debian/prerm debian/tmp/DEBIAN/
+       install -m 755 debian/postinst debian/tmp/DEBIAN/
+       install -m 755 debian/postrm debian/tmp/DEBIAN/
        dh_strip -Pdebian/tmp
        dpkg-gencontrol -isp
-       chown -R root.root debian/tmp
        chmod -R go-ws,go+r debian/tmp
        find debian/tmp -newermt "@$$SOURCE_DATE_EPOCH" -print0 | \
                xargs -0r touch --no-dereference --date="@$$SOURCE_DATE_EPOCH"
-       dpkg --build debian/tmp ..
+       dpkg-deb --root-owner-group --build debian/tmp ..
 
 clean:
        -make clean

I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.

OpenPGP_signature.asc
Description: OpenPGP digital signature