Control: tags -1 patch

On Sat, 7 Dec 2024 20:54:19 +0100 Niels Thykier <[email protected]> wrote:
Source: netselect
Version: 0.3.ds1-30.2
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: [email protected]
User: [email protected]
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
netselect failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

Hi

Please see attached as a patch.

I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.

This package can probably come truly rootless if the upstream makefile could be convinced to not pass `-o root -g root` to `install`. A common trick here is to use `-o $(USER) -g $(GROUP)` and then have the Debian package substitute USER/GROUP with `id -u`/`id -g` (which is a noop but allowed) and then rely on `dh_fixperms` + `dh_builddeb` to build the package with the correct ownership. However, it is was not a minimal patch, so I skipped that for the NMU.

Best regards,
Niels


diff -Nru netselect-0.3.ds1/debian/changelog netselect-0.3.ds1/debian/changelog
--- netselect-0.3.ds1/debian/changelog  2024-03-17 18:12:45.000000000 +0100
+++ netselect-0.3.ds1/debian/changelog  2025-01-01 12:35:50.000000000 +0100
@@ -1,3 +1,11 @@
+netselect (0.3.ds1-30.3) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Make requirement for root when building the package explicit.
+    (Closes: #1089398)
+
+ -- Niels Thykier <[email protected]>  Wed, 01 Jan 2025 11:35:50 +0000
+
 netselect (0.3.ds1-30.2) unstable; urgency=medium
 
   * Non-maintainer upload
diff -Nru netselect-0.3.ds1/debian/control netselect-0.3.ds1/debian/control
--- netselect-0.3.ds1/debian/control    2024-03-17 18:12:17.000000000 +0100
+++ netselect-0.3.ds1/debian/control    2025-01-01 12:35:35.000000000 +0100
@@ -2,6 +2,7 @@
 Section: net
 Priority: optional
 Maintainer: Javier Fernández-Sanguino Peña <[email protected]>
+Rules-Requires-Root: binary-targets
 Standards-Version: 4.5.1
 Build-Depends: debhelper (>= 13), po-debconf
 Homepage: http://github.com/apenwarr/netselect

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to