Bug#1089380: lrzsz: Supporting rootless builds by default

[Niels Thykier]

Control: tags -1 patch

On Sat, 7 Dec 2024 20:41:32 +0100 Niels Thykier <ni...@thykier.net> wrote:

Source: lrzsz
Version: 0.12.21rc-0.1
Severity: important
Tags: ftbfs
Justification: FTBFS
X-Debbugs-Cc: ni...@thykier.net
User: ni...@thykier.net
Usertags: rrr-no-as-default-issue

Dear maintainer,

During a test rebuild for building packages with
`Rules-Requires-Root: no` as the default in `dpkg`,
lrzsz failed to rebuild.

Log Summary:
-------------------------------------------------------------------------------
[...]

Hi

Please see attached as a patch.



Best regards,
Niels

diff -Nru lrzsz-0.12.21rc/debian/changelog lrzsz-0.12.21rc/debian/changelog
--- lrzsz-0.12.21rc/debian/changelog    2024-09-13 08:57:20.000000000 +0200
+++ lrzsz-0.12.21rc/debian/changelog    2025-01-01 13:16:48.000000000 +0100
@@ -1,3 +1,11 @@
+lrzsz (0.12.21rc-0.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Remove need for root when building the package.
+    (Closes: #1089380)
+
+ -- Niels Thykier <ni...@thykier.net>  Wed, 01 Jan 2025 12:16:48 +0000
+
 lrzsz (0.12.21rc-0.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru lrzsz-0.12.21rc/debian/control lrzsz-0.12.21rc/debian/control
--- lrzsz-0.12.21rc/debian/control      2024-09-13 08:57:20.000000000 +0200
+++ lrzsz-0.12.21rc/debian/control      2025-01-01 13:16:18.000000000 +0100
@@ -2,6 +2,7 @@
 Section: comm
 Priority: optional
 Maintainer: Martin A. Godisch <godi...@debian.org>
+Rules-Requires-Root: no
 Standards-Version: 3.9.5
 Build-Depends: debhelper-compat (= 12), gettext
 Homepage: https://ohse.de/uwe/software/lrzsz.html
diff -Nru lrzsz-0.12.21rc/debian/rules lrzsz-0.12.21rc/debian/rules
--- lrzsz-0.12.21rc/debian/rules        2024-09-13 08:57:20.000000000 +0200
+++ lrzsz-0.12.21rc/debian/rules        2025-01-01 13:16:05.000000000 +0100
@@ -1,7 +1,6 @@
 #!/usr/bin/make -f
 
 testdir  = test -f src/lrz.c && test -f debian/rules
-testroot = test x`whoami` = xroot
 
 include /usr/share/dpkg/architecture.mk
 
@@ -36,7 +35,6 @@
 
 clean:
        $(testdir)
-       $(testroot)
        [ ! -f Makefile ] || $(MAKE) clean
        dh_autoreconf_clean
        dh_clean
@@ -47,7 +45,6 @@
 
 binary-arch: build
        $(testdir)
-       $(testroot)
        rm -rf debian/tmp
 
        $(MAKE) prefix=$(CURDIR)/debian/tmp/usr install
@@ -74,13 +71,12 @@
        install -p -m 0644 debian/control debian/tmp/DEBIAN
        cd debian/tmp && find usr -type f -print0 | LC_ALL=C sort -z | xargs -0 
md5sum > DEBIAN/md5sums
 
-       chown -R root:root debian/tmp
        chmod -R go=u-w debian/tmp
 
        dpkg-shlibdeps debian/tmp/usr/bin/*
        dpkg-gencontrol -plrzsz
        find debian/tmp -depth -newermt '$(BUILD_DATE)' -print0 | xargs -0r 
touch --no-dereference --date='$(BUILD_DATE)'
-       dpkg --build debian/tmp ..
+       dpkg-deb --root-owner-group --build debian/tmp ..
 
 binary-indep:
 

I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.

OpenPGP_signature.asc
Description: OpenPGP digital signature