Control: tags -1 patch On Sat, 7 Dec 2024 22:12:15 +0100 Niels Thykier <[email protected]> wrote:
Source: xringd Version: 1.20-27.1 Severity: important Tags: ftbfs Justification: FTBFS X-Debbugs-Cc: [email protected] User: [email protected] Usertags: rrr-no-as-default-issueDear maintainer, During a test rebuild for building packages with `Rules-Requires-Root: no` as the default in `dpkg`, xringd failed to rebuild. Log Summary: ------------------------------------------------------------------------------- [...]
Hi Please see attached as a patch.I intend to NMU to make progress on the MBF if I do not hear from you on this. It would help me if you either uploaded this soon or approved the NMU (enabling me to skip the delay). Thanks in advance.
This package can probably come truly rootless if the upstream makefile could be convinced to not pass `-o root -g root` to `install`. A common trick here is to use `-o $(USER) -g $(GROUP)` and then have the Debian package substitute USER/GROUP with `id -u`/`id -g` (which is a noop but allowed) and then rely on `dh_fixperms` + `dh_builddeb` to build the package with the correct ownership. However, it is was not a minimal patch, so I skipped that for the NMU.
Best regards, Niels
diff -Nru xringd-1.20/debian/changelog xringd-1.20/debian/changelog --- xringd-1.20/debian/changelog 2024-11-17 16:24:13.000000000 +0100 +++ xringd-1.20/debian/changelog 2025-01-01 19:58:12.000000000 +0100 @@ -1,3 +1,11 @@ +xringd (1.20-28.1) unstable; urgency=medium + + * Non-maintainer upload. + * Make requirement for root when building the package explicit. + (Closes: #1089483) + + -- Niels Thykier <[email protected]> Wed, 01 Jan 2025 18:58:12 +0000 + xringd (1.20-28) unstable; urgency=medium * Team upload. diff -Nru xringd-1.20/debian/control xringd-1.20/debian/control --- xringd-1.20/debian/control 2024-11-17 16:24:13.000000000 +0100 +++ xringd-1.20/debian/control 2025-01-01 19:57:43.000000000 +0100 @@ -2,6 +2,7 @@ Section: comm Priority: optional Maintainer: Package Salvaging Team <[email protected]> +Rules-Requires-Root: binary-targets Standards-Version: 4.7.0 Build-Depends: debhelper-compat (= 13) Vcs-Git: https://salsa.debian.org/debian/xringd.git
OpenPGP_signature.asc
Description: OpenPGP digital signature
