Hi Michael, On Thu Jan 9, 2025 at 6:55 PM CET, Michael Biebl wrote: > >> You install systemd-dev (including systemd.pc), the build system picks > >> up the paths from systemd.pc via pkgconf and installs the files into > >> the correct paths. All you need to do in .install is reference the now > >> correct paths. > > > > Then the directive here is to reference a "correct path" in the .install > > file, which presumably is in a variable. (?) Or, whatever the "correct > > path" is meant to mean, I don't know what that is and cannot interpret it. > > No, all you are supposed to do in your .install files is to use the > correct paths > /usr/lib/systemd/system/foo.service > /usr/lib/sysusers.d/foo.conf > /usr/lib/tmpfile.d/foo.conf > > The upstream build system is supposed to install the files directly into > those paths as they are defined in /usr/share/pkgconfig/systemd.pc. > Those paths should be queried by the build system via pkgconfig and not > be hard-coded. > > If it doesn't do that, then there is a bug in the upstream build system > and you should report it as such to upstream. > This is *not* a Debian packaging issue!
I tried it with the attached patch and got the same error as Chris Knadle pointed out, 'even' with 1.5.735 which has the referenced commit/PR. Can you confirm whether the attached patch is the right thing to do on the Debian side? If that's the case, then we know (?) that the problem is indeed (still) in the upstream build system. Or if the patch is incorrect, can you point out why/where and possibly provide an (cmake based) example which I could use as inspiration? Cheers, Diederik
From 8e5db48838309ecc3e13780659a4810584419451 Mon Sep 17 00:00:00 2001 From: Diederik de Haas <didi.deb...@cknow.org> Date: Tue, 14 Jan 2025 14:22:10 +0100 Subject: [PATCH] Simplify installing systemd config files By adding the ``systemd-dev`` package as B-D, then the upstream build system will automatically place the files in their appropriate place. Link: https://bugs.debian.org/1068504 --- debian/control | 3 ++- debian/mumble-server.install | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/debian/control b/debian/control index e702af9..45eec7c 100644 --- a/debian/control +++ b/debian/control @@ -34,7 +34,8 @@ Build-Depends: debhelper-compat (= 13), protobuf-compiler, qtbase5-dev, qttools5-dev, - qttools5-dev-tools + qttools5-dev-tools, + systemd-dev Standards-Version: 4.7.0 Vcs-Browser: https://salsa.debian.org/pkg-voip-team/mumble Vcs-Git: https://salsa.debian.org/pkg-voip-team/mumble.git diff --git a/debian/mumble-server.install b/debian/mumble-server.install index 6205cf0..405b000 100644 --- a/debian/mumble-server.install +++ b/debian/mumble-server.install @@ -2,6 +2,6 @@ usr/bin/mumble-server usr/bin/mumble-server-user-wrapper etc/mumble/mumble-server.ini usr/share/mumble-server/MumbleServer.ice -etc/systemd/system/mumble-server.service usr/lib/systemd/system/ -etc/sysusers.d/mumble-server.conf usr/lib/sysusers.d/mumble-server.conf -etc/tmpfiles.d/mumble-server.conf usr/lib/tmpfiles.d/ +usr/lib/systemd/system/mumble-server.service +usr/lib/sysusers.d/mumble-server.conf +usr/lib/tmpfiles.d/mumble-server.conf -- 2.47.1
signature.asc
Description: PGP signature
