Package: broadcom-sta-dkms
Version: 6.30.223.271-25.1
Severity: important

Dear Maintainer,

I encountered an issue during an `apt upgrade` on Debian where the `broadcom-sta-dkms` package fails to build for the kernel `6.12.12+bpo-amd64`, preventing the kernel and related packages from configuring properly.

### What led up to the situation?
I ran `sudo apt update` followed by `sudo apt upgrade` to update my system, which included upgrading to kernel `6.12.12+bpo-amd64` from backports. During the process, the DKMS build for `broadcom-sta` failed, causing the upgrade to halt with unconfigured packages.

### What exactly did you do (or not do) that was effective (or ineffective)? - I attempted to fix the issue with `sudo dpkg --configure -a` and `sudo apt --fix-broken install`, but the DKMS build error persisted. - I inspected the DKMS log file at `/var/lib/dkms/broadcom-sta/6.30.223.271/build/make.log` to identify the cause.

### What was the outcome of this action?
The upgrade process failed with the following errors:

Setting up linux-image-6.12.12+bpo-amd64 (6.12.12-1~bpo12+1) ...
/etc/kernel/postinst.d/dkms:
Error! Bad return status for module build on kernel: 6.12.12+bpo-amd64 (x86_64) Consult /var/lib/dkms/broadcom-sta/6.30.223.271/build/make.log for more information. dpkg: error processing package linux-image-6.12.12+bpo-amd64 (--configure): installed linux-image-6.12.12+bpo-amd64 package post-installation script subprocess returned error exit status 1

The DKMS log shows a compilation error:

/var/lib/dkms/broadcom-sta/6.30.223.271/build/src/wl/sys/wl_linux.c:59:10: fatal error: asm/unaligned.h: No such file or directory
59 | #include <asm/unaligned.h>
|          ^~~~~~~~~~~~~~~~~
compilation terminated.
make[3]: *** [/usr/src/linux-headers-6.12.12+bpo-common/scripts/Makefile.build:234: /var/lib/dkms/broadcom-sta/6.30.223.271/build/src/wl/sys/wl_linux.o] Error 1

### What outcome did you expect instead?
I expected the `broadcom-sta-dkms` module to build successfully for kernel `6.12.12+bpo-amd64`, allowing the kernel and dependent packages (`linux-image-amd64`, `linux-headers-6.12.12+bpo-amd64`, etc.) to configure and complete the upgrade without errors.

### Additional Information
- The issue appears to stem from the `broadcom-sta` driver expecting `<asm/unaligned.h>`, which is no longer available in newer kernels (replaced by `<linux/unaligned.h>`). - This is likely a compatibility issue with kernel 6.12.12, as the driver source has not been updated to reflect changes in kernel header files.

$ uname -a
Linux jsus 6.5.0-0.deb12.1-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.5.3-1~bpo12+1 (2023-10-08) x86_64 GNU/Linux

j@jsus:~$ apt show libc6 | grep ^Version

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

Version: 2.36-9+deb12u10

### System Information
Debian Release: [e.g., bookworm or bookworm with backports enabled]
APT prefers: [e.g., stable, testing, or backports; specify your sources.list configuration]
Architecture: x86_64
Kernel: Linux 6.12.12+bpo-amd64
Locale: [e.g., en_US.UTF-8]
Shell: /bin/bash
Init: systemd

### Installed Packages
ii broadcom-sta-dkms 6.30.223.271-25.1 all dkms source for the Broadcom STA Wireless driver ii dkms [your version] all Dynamic Kernel Module Support Framework ii linux-image-6.12.12+bpo-amd64 6.12.12-1~bpo12+1 amd64 Linux 6.12.12 for 64-bit PCs

### Suggested Fix
The driver source file `src/wl/sys/wl_linux.c` should be updated to use `#include <linux/unaligned.h>` instead of `<asm/unaligned.h>` to align with modern kernel headers.

Thank you for your attention to this issue! Kind regards,
bobbillybrown

Reply via email to