Package: snapclient
Version: 0.26.0+dfsg1-1~bpo11+1
Severity: normal
Tags: patch
X-Debbugs-Cc: [email protected]

Dear Maintainer,

to reproduce, use the included conf file and start the systemwide 
snapclient.service

expected:         service starts and runs
what happens:     starts and deactivates
suspected cause:  ExecStart=/usr/bin/snapclient --logsink=system 
$SNAPCLIENT_OPTS in snapclient.service

systemd doesn't do shell-like variable substitution, you'd need to start the 
process in a shell
systemd has instead has its own fixed set of %-'speciefiers' for substitution, 
defined in man systemd.unit
luckily, including the SNAPCLIENT_OPTS with the ExecStart= directive, is 
redundant, since snapclient
reads SNAPCLIENT_OPTS from its environment, and the 
EnvironmentFile=-/etc/default/snapclient directive
sources the environment from the conf file. Hence,

suggested patch: ExecStart=/usr/bin/snapclient --logsink=system , without the 
malformed variable

AFAICT, the bug affects not only this version

probably bad practice to mention two bugs in one report, but fwiw, snapclient 
apparantly also has a 
non-robust way of managing its pidfile: running snapclient from the commandline 
as root once, then killing 
it, can lead to Exception: Could not open PID lock file 
"/var/run/snapclient/pid" and failure of the 
service later, alas, I'm failing to reproduce this now that I'd like to give 
exact steps

-- System Information:
Debian Release: 11.7
  APT prefers oldstable-updates
  APT policy: (501, 'oldstable-updates'), (501, 'oldstable')
Architecture: armhf (armv7l)

Kernel: Linux 5.10.0-30-rt-armmp (SMP w/2 CPU threads; PREEMPT)
Kernel taint flags: TAINT_CRAP
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages snapclient depends on:
ii  adduser              3.118
ii  init-system-helpers  1.60
ii  libasound2           1.2.4-1.1
ii  libavahi-client3     0.8-5+deb11u2
ii  libavahi-common3     0.8-5+deb11u2
ii  libc6                2.31-13+deb11u6
ii  libflac8             1.3.3-2+deb11u1
ii  libgcc-s1            10.2.1-6
ii  libogg0              1.3.4-0.1
ii  libopus0             1.3.1-0.1
ii  libpulse0            14.2-2
ii  libsoxr0             0.1.3-4
ii  libstdc++6           10.2.1-6
ii  libvorbis0a          1.3.7-1

Versions of packages snapclient recommends:
ii  avahi-daemon  0.8-5+deb11u2

snapclient suggests no packages.

-- Configuration Files:
/etc/default/snapclient changed:
SNAPCLIENT_OPTS="--host 127.0.0.1 --logfilter=*:warning --daemon=-18"


-- debconf-show failed

Reply via email to