Package: release.debian.org
Severity: normal
X-Debbugs-Cc: gui-...@packages.debian.org
Control: affects -1 + src:gui-ufw
User: release.debian....@packages.debian.org
Usertags: unblock

Please unblock package gui-ufw

[ Reason ]
Gufw is a firewall GUI targeting regular users. Because of an AppStream issue, 
it is not available for installation using GUI in Trixie. This is a problem 
since users are not able to find and install the Gufw package using 
pre-installed GUI package managers such as GNOME Software or KDE Discover.

The package version from unstable proposed for the unblock request adds proper 
AppStream metadata and makes the application installable using GUI.

[ Impact ]
Regular users (and even some more experienced ones who prefer GUI) won't be 
able to find and install this package using GUI. 

[ Tests ]
https://appstream.debian.org/sid/main/metainfo/gufw.html
https://appstream.debian.org/sid/main/issues/gufw.html
(Replace "sid" in URL with "trixie".)

[ Risks ]
Low risk or basically none. The patch is very small and simple. Only one new 
file (/usr/share/metainfo/io.github.costales.gufw.metainfo.xml) is added and 
this file does not conflict with any other package.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]
Original ticket: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095187

There is one more commit that did not make it into Trixie before the freeze, 
but Jeremy Bicha planned to backport:
https://salsa.debian.org/python-team/packages/gui-ufw/-/commit/6babb8b8602771bfaea9883eff3a9b37eafa7176

unblock gui-ufw/24.04.0-3
diff --git a/debian/changelog b/debian/changelog
index a19da6a..6625bfd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+gui-ufw (24.04.0-3) unstable; urgency=medium
+
+  * Add patch to addd AppStream metadata. Closes: #1095187
+
+ -- Daniel Rusek <m...@asciiwolf.com>  Sat, 17 May 2025 00:32:24 +0200
+
 gui-ufw (24.04.0-2) unstable; urgency=medium
 
   * Team upload.
diff --git a/debian/patches/metainfo.patch b/debian/patches/metainfo.patch
new file mode 100644
index 0000000..7fe22e4
--- /dev/null
+++ b/debian/patches/metainfo.patch
@@ -0,0 +1,56 @@
+From: AsciiWolf <m...@asciiwolf.com>
+Date: Tue, 13 May 2025 00:26:18 +0200
+Subject: Add AppStream metadata
+
+Forwarded: https://github.com/costales/gufw/pull/81
+---
+ .../io.github.costales.gufw.metainfo.xml      | 27 +++++++++++++++++++
+ setup.py                                      |  1 +
+ 2 files changed, 28 insertions(+)
+ create mode 100644 data/metainfo/io.github.costales.gufw.metainfo.xml
+
+diff --git a/data/metainfo/io.github.costales.gufw.metainfo.xml 
b/data/metainfo/io.github.costales.gufw.metainfo.xml
+new file mode 100644
+index 0000000..e79f20f
+--- /dev/null
++++ b/data/metainfo/io.github.costales.gufw.metainfo.xml
+@@ -0,0 +1,27 @@
++<?xml version="1.0" encoding="UTF-8"?>
++<component type="desktop-application">
++  <id>io.github.costales.gufw</id>
++  <launchable type="desktop-id">gufw.desktop</launchable>
++  <metadata_license>CC0-1.0</metadata_license>
++  <project_license>GPL-3.0</project_license>
++  <name>Gufw</name>
++  <developer id="io.github.costales">
++    <name>Marcos Costales</name>
++  </developer>
++  <summary>An easy way to configure your firewall</summary>
++  <description>
++    <p>
++      Gufw is an easy to use, intuitive graphical user interface for 
Uncomplicated Firewall (ufw).
++      It supports common tasks such as allowing or blocking pre-configured, 
common p2p, or individual ports, and many others!
++    </p>
++  </description>
++  <screenshots>
++    <screenshot type="default">
++      
<image>https://raw.githubusercontent.com/costales/costales.github.io/refs/heads/master/projects/gufw/gufw.jpg</image>
++    </screenshot>
++  </screenshots>
++  <url type="homepage">https://github.com/costales/gufw</url>
++  <url type="bugtracker">https://github.com/costales/gufw/issues</url>
++  <content_rating type="oars-1.1"/>
++  <translation type="gettext">gufw</translation>
++</component>
+diff --git a/setup.py b/setup.py
+index a228345..7160ab0 100755
+--- a/setup.py
++++ b/setup.py
+@@ -22,6 +22,7 @@ import glob
+ 
+ # Create data files
+ data = [ ('/usr/share/polkit-1/actions/', 
['policykit/actions/com.ubuntu.pkexec.gufw.policy']),
++         ('/usr/share/metainfo/',         
['data/metainfo/io.github.costales.gufw.metainfo.xml']),
+          ('/etc/gufw/app_profiles',       glob.glob("data/app_profiles/*.*")) 
]
+ 
+ # Setup stage
diff --git a/debian/patches/series b/debian/patches/series
index b316da3..7a661b1 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 webkit.patch
+metainfo.patch

Reply via email to