Hello, On Mon 09 Jun 2025 at 10:49am +01, Ian Jackson wrote:
> Package: git-debpush
> Version: 13.13
>
> Ian Jackson writes ("Re: [PATCH fyi 3/4] git-debpush: When tests fail, prompt
> to proceed as though --force"):
>> The approach you have taken invites the user to confirm *all* failed
>> checks in one go, with a prompt that doesn't list them - it doesn't
>> even say how many things you're overriding.
>
> IMO, this is settng the user up for a fall. They can easily say "yes"
> to one thing and also override another, by mistake.
>
> git-debrebase and dgit have options that allow you to override a
> specific thing. This is cumbersome, but reliable. We want to make
> git-debpush easy to use, so we're not encouraging people to try to
> remember a --force-snoozy-wombats or whatever.
>
> But this reasoning doesn't apply when we're prompting the user. The
> user doens't need to type the name of the failed check. They can read
> it on the screen.
>
> So IMO we should prompt once for each failed check, so that the thing
> the user is overriding always appears immediately before the prompt.
>
> Multiple prompts also provides a barrier to an error when the user is
> expecting a prompt and hits "y" by reflex. If they get an unexpected
> prompt as well as the expected one, they have a chance to notice that
> something is wrong.
>
> (I think that we can only detect each problem once, so we don't need a
> data structure to dedupe them or anything. Instead, we could move the
> prompting to the detection site.)
Yes, you're right, it should prompt for each failure. I'll work on
that.
--
Sean Whitton
signature.asc
Description: PGP signature
