Hi Nicholas,
On 15/06/2025 20:57, Nicholas D Steeves wrote:
Hi Lee,
Lee Garrett <[email protected]> writes:
Hi everyone,
I'm in the final stages of creating borgbackup 1.4.1-3 (some packaging fixes and
adding autopkgtests), I'll upload it today or tomorrow and then also file an
unblock request.
Greets,
Lee
Thank you for your work doing various cleanup. Are you aware that the
release team may look at the diff and say "these are too many changes,
so we're refusing the unblock"? In particular, how do you know that the
proposed autopkgtests won't cause borgbackup to fall out of trixie due
to new failing autopkgtests on arm64? Potentially requiring a second
upload to fix the first, and a second upload...do you think that meets
the criteria for the hard freeze?
borgbackup is a key package, so it won't get removed unless a release manager
does it manually. IMHO, if the autopkgtests fail on arm64, it would be good to
take a very close look why they fail, since this could very well mean that borg
is broken on arm64.
The principle is thus: we want to unblock the package people have been
using and the one whose behaviour has data on buildd, reprobuilds,
DebCI, etc. Changes that don't have supporting data from these sources
introduce risk, even if they're good changes! :)
I don't intend to change the way the package builds. Currently, only
simplesession-nofuse is even running on debci, since tests with
isolation-container restrictions are skipped. Having better autopkgtests ensures
that any regressions due to (build) dependency updates will be noticed. And
especially elbrus is happy when there are more autopkgtests. :)
I'm in the process of preparing a minimal fix to NEWS as well as
documenting the upstream changes so that the release team can assess the
potential risk of unblocking the release. I'll push to a debian/trixie
branch. I will wait to upload until everyone hears back from you,
because that's the collaborative approach.
I'm happy to push my changes for you to review before upload. I'd wait with the
debian/trixie branch until the release, to avoid debian/latest and debian/trixie
to become out of sync.
Regards,
Nicholas
All the best!
Lee
