Package: release.debian.org
Severity: normal
X-Debbugs-Cc: gnome-ca...@packages.debian.org
Control: affects -1 + src:gnome-calls
User: release.debian....@packages.debian.org
Usertags: unblock
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Please unblock package gnome-calls
[ Reason ]
Fixes placing SIP call being almost impossible
Fixes broken USSD dialog
(Fixes metainfo validation)
[ Impact ]
The SIP plugin is pretty much unusable
and USSD dialogs are completely broken.
[ Tests ]
These changes have been carefully reviewed and manually tested
by multiple people upstream.
[ Risks ]
None that I can see,
the changeset is targetted and comparatively small in nature.
gnome-calls is a leaf package,
so there is no risk of breaking dependants.
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing
[ Other info ]
The metainfo changes are not required on buildd,
but lead to FTBFS on developer machines where appstreamcli(1) is installed
as `appstreamcli validate $metainfo_file` will then be invoked
in upstreams test suite which then fails, so would also be nice to have.
unblock gnome-calls/48.2-1
*** /home/fortysixandtwo/calls_48.1-1_48.2-1.debdiff
diff -Nru gnome-calls-48.1/data/org.gnome.Calls.metainfo.xml.in
gnome-calls-48.2/data/org.gnome.Calls.metainfo.xml.in
- --- gnome-calls-48.1/data/org.gnome.Calls.metainfo.xml.in 2025-04-10
18:34:10.000000000 +0200
+++ gnome-calls-48.2/data/org.gnome.Calls.metainfo.xml.in 2025-05-24
18:21:17.000000000 +0200
@@ -69,6 +69,19 @@
<content_rating type="oars-1.1"/>
<releases>
+ <release version="48.2" date="2025-05-24">
+ <description>
+ <p>
+ Bugfix release
+ </p>
+ <ul>
+ <li>Fix crash on shutdown</li>
+ <li>Fix not properly switching between keypad and text entry</li>
+ <li>Fix USSD dialog becoming hidden, turning the whole application
unresponsive</li>
+ </ul>
+ </description>
+ </release>
+
<release version="48.1" date="2025-04-10">
<description>
<p>
diff -Nru gnome-calls-48.1/debian/changelog gnome-calls-48.2/debian/changelog
- --- gnome-calls-48.1/debian/changelog 2025-04-10 19:04:40.000000000 +0200
+++ gnome-calls-48.2/debian/changelog 2025-07-03 23:19:44.000000000 +0200
@@ -1,3 +1,19 @@
+gnome-calls (48.2-1) unstable; urgency=medium
+
+ * New upstream release
+ * Fix USSD dialog locking up the UI (Closes: #1108256)
+ * d/patches: Remove patches applied upstream
+ * d/patches: Allows metainfo validation to pass
+
+ -- Evangelos Ribeiro Tzaras <dev...@fortysixandtwo.eu> Thu, 03 Jul 2025
23:19:44 +0200
+
+gnome-calls (48.1-2) unstable; urgency=medium
+
+ * call-box: Use correct property.
+ This allows to dial out SIP addresses again
+
+ -- Guido Günther <a...@sigxcpu.org> Sun, 04 May 2025 09:51:52 +0200
+
gnome-calls (48.1-1) unstable; urgency=medium
* New upstream release
diff -Nru gnome-calls-48.1/debian/patches/make_metainfo_pass_validation.patch
gnome-calls-48.2/debian/patches/make_metainfo_pass_validation.patch
- --- gnome-calls-48.1/debian/patches/make_metainfo_pass_validation.patch
1970-01-01 01:00:00.000000000 +0100
+++ gnome-calls-48.2/debian/patches/make_metainfo_pass_validation.patch
2025-07-03 23:19:44.000000000 +0200
@@ -0,0 +1,45 @@
+From: Evangelos Ribeiro Tzaras <dev...@fortysixandtwo.eu>
+Date: Sat, 24 May 2025 20:30:56 +0200
+Subject: metainfo: Wrap old release notes in paragraph
+
+This fixes the following warnings in `appstreamcli validate`:
+
+W: org.gnome.Calls:239: description-spurious-text
+ The description element contains raw text that is not in any paragraph or
other permitted tag.
+ This is not allowed and the additional text may be ignored by parsers or
raise errors.
+
+W: org.gnome.Calls:239: description-no-valid-content
+ The description element does not contain any valid content (paragraphs,
enumerations, etc.).
+
+Signed-off-by: Evangelos Ribeiro Tzaras <dev...@fortysixandtwo.eu>
+Part-of: <https://gitlab.gnome.org/GNOME/calls/-/merge_requests/781>
+(cherry picked from commit e170a76bc9f84ef7a92e6ac64f286afecd448afd)
+---
+ data/org.gnome.Calls.metainfo.xml.in | 8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/data/org.gnome.Calls.metainfo.xml.in
b/data/org.gnome.Calls.metainfo.xml.in
+index 0c73174..95d1808 100644
+--- a/data/org.gnome.Calls.metainfo.xml.in
++++ b/data/org.gnome.Calls.metainfo.xml.in
+@@ -274,16 +274,16 @@
+ </description>
+ </release>
+ <release version="41.0" date="2021-09-18">
+- <description>SIP plugin bugfixes.</description>
++ <description><p>SIP plugin bugfixes.</p></description>
+ </release>
+ <release version="41~rc" date="2021-09-02">
+- <description>SIP Plugin polish and bugfixes.</description>
++ <description><p>SIP Plugin polish and bugfixes.</p></description>
+ </release>
+ <release version="41~beta" date="2021-08-14">
+- <description>SIP Plugin usable from the UI.</description>
++ <description><p>SIP Plugin usable from the UI.</p></description>
+ </release>
+ <release version="41~alpha" date="2021-07-16">
+- <description>First GNOME release</description>
++ <description><p>First GNOME release</p></description>
+ </release>
+ </releases>
+
diff -Nru gnome-calls-48.1/debian/patches/series
gnome-calls-48.2/debian/patches/series
- --- gnome-calls-48.1/debian/patches/series 2025-04-10 19:04:40.000000000
+0200
+++ gnome-calls-48.2/debian/patches/series 2025-07-03 23:19:44.000000000
+0200
@@ -1,2 +1,3 @@
disable-flaky-sip-test.patch
disable-application-test.patch
+make_metainfo_pass_validation.patch
diff -Nru gnome-calls-48.1/meson.build gnome-calls-48.2/meson.build
- --- gnome-calls-48.1/meson.build 2025-04-10 18:34:10.000000000 +0200
+++ gnome-calls-48.2/meson.build 2025-05-24 18:21:17.000000000 +0200
@@ -22,7 +22,7 @@
project(
'calls',
'c', 'vala',
- - version: '48.1',
+ version: '48.2',
license: 'GPLv3+',
meson_version: '>= 1.0',
default_options: [
diff -Nru gnome-calls-48.1/NEWS gnome-calls-48.2/NEWS
- --- gnome-calls-48.1/NEWS 2025-04-10 18:34:10.000000000 +0200
+++ gnome-calls-48.2/NEWS 2025-05-24 18:21:17.000000000 +0200
@@ -1,3 +1,14 @@
+gnome-calls 48.2
+----------------
+Released May 2025
+* Fix crash on shutdown
+* Fix not properly switching between keypad and text entry
+* Fix USSD dialog getting hidden, turning the whole application unresponsive
+* Contributors:
+ * Guido Günther
+ * knoppix
+ * Vivek wagdare
+
gnome-calls 48.1
----------------
Released April 2025
diff -Nru gnome-calls-48.1/src/calls-account-overview.c
gnome-calls-48.2/src/calls-account-overview.c
- --- gnome-calls-48.1/src/calls-account-overview.c 2025-04-10
18:34:10.000000000 +0200
+++ gnome-calls-48.2/src/calls-account-overview.c 2025-05-24
18:21:17.000000000 +0200
@@ -401,7 +401,7 @@
account_provider_filter = GTK_FILTER (gtk_custom_filter_new
(match_account_provider, NULL, NULL));
self->providers =
- - G_LIST_MODEL (gtk_filter_list_model_new (all_providers,
account_provider_filter));
+ G_LIST_MODEL (gtk_filter_list_model_new (g_object_ref (all_providers),
account_provider_filter));
g_signal_connect (self->providers,
"items-changed",
@@ -413,7 +413,7 @@
account_filter = GTK_FILTER (gtk_custom_filter_new (match_account, NULL,
NULL));
self->accounts =
- - G_LIST_MODEL (gtk_filter_list_model_new (all_origins, account_filter));
+ G_LIST_MODEL (gtk_filter_list_model_new (g_object_ref (all_origins),
account_filter));
g_signal_connect_object (self->accounts,
"items-changed",
G_CALLBACK (on_accounts_changed),
diff -Nru gnome-calls-48.1/src/calls-main-window.c
gnome-calls-48.2/src/calls-main-window.c
- --- gnome-calls-48.1/src/calls-main-window.c 2025-04-10 18:34:10.000000000
+0200
+++ gnome-calls-48.2/src/calls-main-window.c 2025-05-24 18:21:17.000000000
+0200
@@ -201,7 +201,6 @@
adw_dialog_close (self->ussd_dialog);
}
- -
static void
window_ussd_entry_changed_cb (CallsMainWindow *self,
GtkEntry *entry)
diff -Nru gnome-calls-48.1/src/ui/contacts-box.ui
gnome-calls-48.2/src/ui/contacts-box.ui
- --- gnome-calls-48.1/src/ui/contacts-box.ui 2025-04-10 18:34:10.000000000
+0200
+++ gnome-calls-48.2/src/ui/contacts-box.ui 2025-05-24 18:21:17.000000000
+0200
@@ -9,6 +9,8 @@
<object class="GtkSearchEntry" id="search_entry">
<property name="margin-start">12</property>
<property name="margin-end">12</property>
+ <property name="margin-top">12</property>
+ <property name="margin-bottom">12</property>
</object>
</child>
</object>
diff -Nru gnome-calls-48.1/src/ui/main-window.ui
gnome-calls-48.2/src/ui/main-window.ui
- --- gnome-calls-48.1/src/ui/main-window.ui 2025-04-10 18:34:10.000000000
+0200
+++ gnome-calls-48.2/src/ui/main-window.ui 2025-05-24 18:21:17.000000000
+0200
@@ -85,7 +85,7 @@
<property name="focus-on-click">False</property>
<property name="use-underline">True</property>
<property name="label" translatable="yes">_Close</property>
- - <signal name="clicked" handler="gtk_widget_hide"
object="ussd_dialog" swapped="yes"/>
+ <signal name="clicked" handler="adw_dialog_close"
object="ussd_dialog" swapped="yes"/>
</object>
</child>
<child type="end">
diff -Nru gnome-calls-48.1/src/ui/new-call-box.ui
gnome-calls-48.2/src/ui/new-call-box.ui
- --- gnome-calls-48.1/src/ui/new-call-box.ui 2025-04-10 18:34:10.000000000
+0200
+++ gnome-calls-48.2/src/ui/new-call-box.ui 2025-05-24 18:21:17.000000000
+0200
@@ -20,7 +20,7 @@
<property name="halign">center</property>
<child>
<object class="AdwComboRow" id="origin_list">
- - <signal name="notify::selected-index"
handler="notify_selected_index_cb" swapped="yes"/>
+ <signal name="notify::selected"
handler="notify_selected_index_cb" swapped="yes"/>
</object>
</child>
</object>
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEuThlVLfdJmvLjimpkPDJsYprShkFAmhnCegACgkQkPDJsYpr
Shki/Q/+MNpcrJbb6CghCfrIj2zSWGfv0g2yLLAG4vvveX12OIuEn/NrQ+e8+dYW
syY7B0DW652kzkYxU8aZCqoa4ljl8d6+0i9PmHEJe18ANTq2SrpIFsbaUZn6NlB0
apJMeJTPPD/d8sELOtdvI3XByZUKmmWjFoqxV3sGfxaXL/oWxVSFjffKJfRXMbdY
IOvHrTyoGC8fwLbMebxc+7UfDa2kDS37dp966Nua/78G8RfGz38qRGGBm5/lop4p
i/OfWdqwRXZglmZvkcjG7MHQTaZuszoW79OrApS1xwSo7pMZTVNWI/a0X5AOjZN+
+Lk+N177DZVoQDRXdPFnLG/kR9P4mNFFW9EjcFz1aLNTaVCSIEQfiD1PQmupn7tG
zPs7G3Zjial1vVkiWzzCid7ugjl3MtfXU0wiGuflSTiNck9vJFyWY6Hm2Zy0XQQf
BVOQ05DhIKaFzFd8fS9BuJH723z53HaynAi7g4s/Yhb+VVKEX3BT7ILmHhNP1iLG
eSnhBcG81qlT+rw0ZPD+0Ud0SXXn+5Mm8lisULckI/aR2sAm5JTstPQD8Pi0qSwU
Px5Y6Sz1BgSgEC+F2IOkCNJ2Ng9eK+fjTHo0e9zebCpmD62JWwMNwUa7LZnfqXii
YfHsKVXB6nTU516orLUZeF2+g2RxG3YqJMnxTE2beCr7d09AJCw=
=yFjr
-----END PGP SIGNATURE-----
