Hello, On Mon 21 Jul 2025 at 07:32pm +02, Andrea Pappacoda wrote:
> diff --git a/git-debpush b/git-debpush
> index e3a4ba39..1782513e 100755
> --- a/git-debpush
> +++ b/git-debpush
> @@ -457,6 +457,16 @@ if $upstream; then
> to_push+=("$upstream_tag")
> fi
>
> +# TODO: pristine-tar
> +# I obtain the commit ID at the time of the upload, so that I can be sure
> that
> +# the tag2upload service generates the tarball with the expected pristine-tar
> +# branch state
> +pristine_tar_info=''
> +if pristine_tar_commit=$(git rev-parse --verify --quiet
> 'refs/heads/pristine-tar'); then
> + pristine_tar_info=" pristine-tar=$pristine_tar_commit"
> +fi
> +
> +
> #**** Useful sanity checks ****
There is already some pristine-tar stuff in git-debpush, the "Intent to
use pristine-tar for this upload" check. I think that your changes
should be integrated with that. I.e., the conditions under which we
currently fail because we think the user wants to use pristine-tar,
should be precisely the conditions in which pristine_tar= gets added to
the tag.
As for everything else, I'll assume Ian's review probably covered it,
and I'll take a closer look at your v2. Thank you for helping us with
this.
--
Sean Whitton
signature.asc
Description: PGP signature
