On 2025-08-13, at 23:47:03 +0200, Andreas Beckmann wrote:
Package: xtables-addons-dkms Version: 3.28-1 Severity: important Tags: upstreamHi, the module fails to build for src:linux 6.16-1~exp1 in experimental: ... # CC [M] pknock/xt_pknock.o x86_64-linux-gnu-gcc-14 -Wp,-MMD,pknock/.xt_pknock.o.d -nostdinc -I/usr/src/linux-headers-6.16-common/arch/x86/include -I/usr/src/linux-headers-6.16-amd64/arch/x86/include/generated -I/usr/src/linux-headers-6.16-common/include -I/usr/src/linux-headers-6.1 6-amd64/include -I/usr/src/linux-headers-6.16-common/arch/x86/include/uapi -I/usr/src/linux-headers-6.16-amd64/arch/x86/include/generated/uapi -I/usr/src/linux-headers-6.16-common/include/uapi -I/usr/src/linux-headers-6.16-amd64/include/generated/uapi -inclu de /usr/src/linux-headers-6.16-common/include/linux/compiler-version.h -include /usr/src/linux-headers-6.16-common/include/linux/kconfig.h -include /usr/src/linux-headers-6.16-common/include/linux/compiler_types.h -D__KERNEL__ -std=gnu11 -fshort-wchar -funsi gned-char -fno-common -fno-PIE -fno-strict-aliasing -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx -fcf-protection=branch -fno-jump-tables -m64 -falign-jumps=1 -falign-loops=1 -mno-80387 -mno-fp-ret-in-387 -mpreferred-stack-boundary=3 -mskip-rax-setup -marc h=x86-64 -mtune=generic -mno-red-zone -mcmodel=kernel -mstack-protector-guard-reg=gs -mstack-protector-guard-symbol=__ref_stack_chk_guard -Wno-sign-compare -fno-asynchronous-unwind-tables -mindirect-branch=thunk-extern -mindirect-branch-register -mindirect-b ranch-cs-prefix -mfunction-return=thunk-extern -fno-jump-tables -mharden-sls=all -fpatchable-function-entry=16,16 -fno-delete-null-pointer-checks -O2 -fno-allow-store-data-races -fstack-protector-strong -ftrivial-auto-var-init=zero -fno-stack-clash-protectio n -pg -mrecord-mcount -mfentry -DCC_USING_FENTRY -fmin-function-alignment=16 -fstrict-flex-arrays=3 -fno-strict-overflow -fno-stack-check -fconserve-stack -fno-builtin-wcslen -Wall -Wextra -Wundef -Werror=implicit-function-declaration -Werror=implicit-int -W error=return-type -Werror=strict-prototypes -Wno-format-security -Wno-trigraphs -Wno-frame-address -Wno-address-of-packed-member -Wmissing-declarations -Wmissing-prototypes -Wframe-larger-than=2048 -Wno-main -Wno-dangling-pointer -Wvla-larger-than=1 -Wno-poi nter-sign -Wcast-function-type -Wno-array-bounds -Wno-stringop-overflow -Wno-alloc-size-larger-than -Wimplicit-fallthrough=5 -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wenum-conversion -Wunused -Wno-unused-but-set-variable -Wno-unused-const-variable -Wno-packed-not-aligned -Wno-format-overflow -Wno-format-truncation -Wno-stringop-truncation -Wno-override-init -Wno-missing-field-initializers -Wno-type-limits -Wno-shift-negative-value -Wno-maybe-uninitialized -Wno-sign-compare - Wno-unused-parameter -g -I./pknock/.. -fsanitize=bounds-strict -fsanitize=shift -DMODULE -DKBUILD_BASENAME='"xt_pknock"' -DKBUILD_MODNAME='"xt_pknock"' -D__KBUILD_MODNAME=kmod_xt_pknock -c -o pknock/xt_pknock.o pknock/xt_pknock.c ; /usr/src/linux-head ers-6.16-amd64/tools/objtool/objtool --hacks=jump_label --hacks=noinstr --hacks=skylake --ibt --orc --retpoline --rethunk --sls --static-call --uaccess --prefix=16 --link --module pknock/xt_pknock.o # cmd_mod pknock/xt_pknock.mod printf '%s ' xt_pknock.o | awk '!x[$0]++ { print("pknock/"$0) }' > pknock/xt_pknock.mod ... pknock/xt_pknock.c: In function 'peer_gc': pknock/xt_pknock.c:362:39: error: implicit declaration of function 'from_timer'; did you mean 'mod_timer'? [-Wimplicit-function-declaration] 362 | struct xt_pknock_rule *rule = from_timer(rule, tl, timer); | ^~~~~~~~~~ | mod_timer pknock/xt_pknock.c:362:60: error: 'timer' undeclared (first use in this function); did you mean 'ktimerd'? 362 | struct xt_pknock_rule *rule = from_timer(rule, tl, timer); | ^~~~~ | ktimerd pknock/xt_pknock.c:362:60: note: each undeclared identifier is reported only once for each function it appears in make[4]: *** [/usr/src/linux-headers-6.16-common/scripts/Makefile.build:292: pknock/xt_pknock.o] Error 1 ... Should be related to Linux commit https://github.com/torvalds/linux/commit/41cb08555c4164996d67c78b3bf1c658075b75f1 "treewide, timers: Rename from_timer() to timer_container_of()"
Thanks for the warning. Will let upstream know and get this fixed. J.
signature.asc
Description: PGP signature
