On Sun, Feb 01, 2026 at 07:54:40AM +0200, Carsten Schoenert wrote:
> Hello Matheus,
> 
> Am Fri, Jan 30, 2026 at 01:54:17AM -0300 schrieb Matheus Polkorny:
> .. 
> I'm willing to have a look and sponsor your work.
> 
> As the source package is team maintained and the packaging is happen
> within a git tree could you please fork the team packaging tree from
> https://salsa.debian.org/python-team/packages/starlette
> and create a new branch 'debian/trixie' starting on top of the tag
> 'debian/0.46.1-3'?
> Place your modifications afterwards onto this.

I created the fork before this first upload to mentors.
It is available here:
https://salsa.debian.org/polkorny/starlette/-/tree/debian/trixie

> 
> If you do so please mind to ialso adjust debian/gbp.conf to the new
> branch name.
> Preparing an upload based on a git tree makes working and üreparing the
> stuff much more easy.

Done

> 
> You could then also just cherry-pick the adjustment of the
> debian/changelog file from Piotr.
> 
> git cherry-pick -x a6c184cb0f39188a33354dc4db97e9b7fbe0107f

Done

> 
> Please also document where you have taken the patch from.
> My guess is this is commit 
> https://github.com/Kludex/starlette/commit/4ea6e22b489ec388d6004cfbca52dd5b147127c5
> But people should not need to spend time to find this out by searching
> but rather see by comparing your modifications are the same and based on
> some referenced source.
> 
> There is https://dep-team.pages.debian.net/deps/dep3/ about some
> additional header data to make it more clear and obvious what the patch
> is about and there it is come from. Have a look at the end of the
> document so see some examples.

Yes, I forgot the Origin field.

> 
> Another suggestion:
> Please make the entry in debian/changelog about the fix more easy to
> read.
> The first I'd look for is to easy catch the CVE number(s) which got fixed
> in the uploaded version. I'm just interested in how this was done by a
> second view. Less text is more here. Get some inspiration
> what I mean here e.g.:
> 
> https://tracker.debian.org/news/1592590/accepted-python-werkzeug-222-3deb12u1-source-into-proposed-updates/

Done

I opened an MR in my personal Debian git against trixie
(debian/0.46.1-3).
It seems easier to see what changed between the first upload and this
second one after review.

The diff between the first and second upload is available here:
https://salsa.debian.org/polkorny/starlette/-/merge_requests/1/diffs?diff_id=527535&start_sha=52491ca9146cbff41636a0a0334fa310cd135f8d

> 
> Regrads
> Carsten
> 

PS. I also uploaded the package to debusine to verify that everything
is ok. I am not sure whether I or you will open the bug-pu,
but in any case the debdiff is already available there.
https://debusine.debian.net/debian/developers/work-request/366594/
-- 
Thanks,
Polkorny

Attachment: signature.asc
Description: PGP signature

Reply via email to