Package: vgrabbj
Severity: normal
Tags: patch

When building 'vgrabbj' on amd64 with gcc-4.0,
I get the following error:

vgrabbj.h:296: error: previous declaration of 'l_opt' was here
v_config.c: In function 'init_defaults':
v_config.c:150: error: invalid lvalue in unary '&'
v_config.c:151: error: invalid lvalue in unary '&'
v_config.c:152: error: invalid lvalue in unary '&'
v_config.c:154: error: invalid lvalue in unary '&'
v_config.c:157: error: invalid lvalue in unary '&'
v_config.c:163: error: invalid lvalue in unary '&'
v_config.c:164: error: invalid lvalue in unary '&'
v_config.c:177: error: invalid lvalue in unary '&'
v_config.c:178: error: invalid lvalue in unary '&'
v_config.c:179: error: invalid lvalue in unary '&'
v_config.c:180: error: invalid lvalue in unary '&'
v_config.c:198: error: invalid lvalue in unary '&'
v_config.c: In function 'decode_options':
v_config.c:421: warning: cast from pointer to integer of different size
v_config.c:421: error: invalid lvalue in assignment
make[1]: *** [v_config.o] Error 1
make[1]: Leaving directory `/vgrabbj-0.9.3'
make: *** [build-stamp] Error 2

With the attached patch 'vgrabbj' can be compiled
on amd64 using gcc-4.0.

Regards
Andreas Jochens

diff -urN ../tmp-orig/vgrabbj-0.9.3/v_config.c ./v_config.c
--- ../tmp-orig/vgrabbj-0.9.3/v_config.c        2002-10-15 21:30:57.000000000 
+0200
+++ ./v_config.c        2005-03-03 18:57:25.350373678 +0100
@@ -147,21 +147,21 @@
   vconf->tmpout     = NULL;
   vconf->buffer     = NULL;
   vconf->o_buffer   = NULL;
-  l_opt[0].var = &(int)vconf->debug;
-  l_opt[1].var = &(long int)vconf->loop;
-  l_opt[2].var = &(long int)vconf->loop;
+  l_opt[0].var = &vconf->debug;
+  l_opt[1].var = &vconf->loop;
+  l_opt[2].var = &vconf->loop;
   l_opt[3].var = &vconf->brightness;
-  l_opt[4].var = &(int)vconf->quality;
+  l_opt[4].var = &vconf->quality;
   l_opt[6].var = &vconf->win.width;
   l_opt[7].var = &vconf->win.height;
-  l_opt[8].var = &(int)vconf->outformat;
+  l_opt[8].var = &vconf->outformat;
   l_opt[9].var = (char *)vconf->out;
   l_opt[10].var = (char *)vconf->in;
   l_opt[11].var = &vconf->openonce;
   l_opt[12].var = &vconf->switch_bgr;
   l_opt[13].var = &vconf->windowsize;
-  l_opt[14].var = &(int)vconf->discard;
-  l_opt[15].var = &(int)vconf->forcepal;
+  l_opt[14].var = &vconf->discard;
+  l_opt[15].var = &vconf->forcepal;
   l_opt[16].var = &vconf->usetmpout;
   l_opt[17].var = &vconf->use_ts;
 #ifdef LIBTTF
@@ -174,10 +174,10 @@
   vconf->blend      = DEFAULT_BLEND;
   l_opt[18].var = (char *)vconf->font;
   l_opt[19].var = (char *)vconf->timestamp;
-  l_opt[20].var = &(int)vconf->font_size;
-  l_opt[21].var = &(int)vconf->align;
-  l_opt[22].var = &(int)vconf->blend;
-  l_opt[23].var = &(int)vconf->border;
+  l_opt[20].var = &vconf->font_size;
+  l_opt[21].var = &vconf->align;
+  l_opt[22].var = &vconf->blend;
+  l_opt[23].var = &vconf->border;
 #endif
 #ifdef LIBFTP
   vconf->ftp.enable          = FALSE;
@@ -195,7 +195,7 @@
   l_opt[27].var = (char *)vconf->ftp.username;
   l_opt[28].var = (char *)vconf->ftp.password;
   l_opt[29].var = &vconf->ftp.keepalive;
-  l_opt[30].var = &(unsigned int)vconf->ftp.tryharder;
+  l_opt[30].var = &vconf->ftp.tryharder;
   l_opt[31].var = (char *)vconf->ftp.remoteDir;
 #endif
   vconf->archive     = NULL;
@@ -417,7 +417,7 @@
                                              n, l_opt[i]) ? TRUE : FALSE;
        break;
       case opt_charptr:
-       (int *)l_opt[i].var=(int)check_maxlen(vconf, get_str(value, (char 
*)l_opt[i].var),
+       l_opt[i].var=(int)check_maxlen(vconf, get_str(value, (char 
*)l_opt[i].var),
                                              l_opt[i], n);
        break;
       case opt_format:
diff -urN ../tmp-orig/vgrabbj-0.9.3/v_options.h ./v_options.h
--- ../tmp-orig/vgrabbj-0.9.3/v_options.h       2002-10-15 21:24:27.000000000 
+0200
+++ ./v_options.h       2005-03-03 18:58:10.960570068 +0100
@@ -23,7 +23,7 @@
 
 /* Includes */
 
-static struct v_options l_opt[] = {
+struct v_options l_opt[] = {
   /* Here's the whole definition of options of vgrabbj with needed 
information: (it fits MY screen ;-)
    *
    * arg_type: 1=int, 2=longint, 3=bool, 4=char, 0=unspecified


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to