Package: micro
Version: 2.0.15-2
Severity: minor
Tags: patch
X-Debbugs-Cc: [email protected]

Hello Utkarsh, Nilesh, and the rest of the Debian micro team past and
present. Thank you for maintaining this nice package over the years!

I've a couple of related suggestions and a combined patch that I think
would help improve its desktop integration. Or at least, to bring it
closer to what I think upstream are probably intending with their supplied
desktop integration files. I'd love it if you could consider updating the
package with my changes.

 1. Please can you remove 02-fix-desktop-file.patch, and instead deploy
    upstream's icon into /usr/share/icons/hicolor/scalable/apps? In the
    package's current state, the user is not able to change the displayed
    icon by installing an icon theme[1] because the Icon= path is
    hardcoded to "/usr/share/micro/assets/micro-logo-mark.svg".

 2. Upstream have been shipping a Metainfo file since 2023. Please can
    you update the Debian package to deploy it? It will close a warning[2]
    of about the same age in the package tracking system[3].

The patch is quite short, so I've inlined it below. Note that micro now
build-depends on dh-exec, and micro.install must be made executable as
well in Salsa. This way might be more elegant? I think that using dh-exec
to install the icon file under upstream's preferred Icon= name is
technically better too, and should avoid any regression on #1047981. I
haven't noticed any inability to build local sources after a binary build,
or vice versa with these changes, so that seems hopeful.

Looking at the Salsa sources, I assume that Nilesh chose the
/usr/share/micro location as simply a place to drop the logo file back
when it couldn't be renamed by plain old dh_install. That location seems
not to be touched by upstream, and it's not depended upon by any installed
documentation as far as I can tell.

Also of note: upstream appear to be in the process of changing their
GitHub URL. I assume that's on your radar, though.


    Thanks in advance for considering these changes,
    Andrew.


[1] Such icon themes do exist, and I contribute to one occasionally :)
    
https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/blob/master/Papirus/64x64/apps/micro.svg
[2] https://appstream.debian.org/sid/main/issues/micro.html
[3] https://tracker.debian.org/pkg/micro


PATCH NOTE: micro.install must be made executable.

-------------------- 8< --------------------
diff -rU2 debian.OLD/control debian/control
--- debian.OLD/control  2026-01-17 16:14:36.000000000 +0000
+++ debian/control      2026-05-07 22:58:17.185158099 +0100
@@ -6,4 +6,5 @@
 Build-Depends: debhelper-compat (= 13),
                dh-golang,
+               dh-exec,
                golang-any,
                golang-github-blang-semver-dev,
diff -rU2 debian.OLD/micro.install debian/micro.install
--- debian.OLD/micro.install    2026-01-17 15:39:12.000000000 +0000
+++ debian/micro.install        2026-05-07 22:55:56.148014435 +0100
@@ -1,2 +1,4 @@
-assets/micro-logo-mark.svg     usr/share/micro/
+#!/usr/bin/dh-exec --with=install
+assets/micro-logo-mark.svg => usr/share/icons/hicolor/scalable/apps/micro.svg
 assets/packaging/micro.desktop usr/share/applications/
+data/io.github.zyedidia.micro.metainfo.xml  usr/share/appdata/
Only in debian.OLD/patches: 02-fix-desktop-file.patch
diff -rU2 debian.OLD/patches/series debian/patches/series
--- debian.OLD/patches/series   2026-01-17 15:46:20.000000000 +0000
+++ debian/patches/series       2026-05-07 21:56:57.999054974 +0100
@@ -1,2 +1 @@
 01-disable-commit-hash-and-date.patch
-02-fix-desktop-file.patch
-------------------- >8 --------------------


-- System Information:
Debian Release: forky/sid
  APT prefers testing
  APT policy: (900, 'testing'), (5, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.19.14+deb14-amd64 (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_WARN
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages micro depends on:
ii  libc6  2.42-15

Versions of packages micro recommends:
ii  xclip  0.13-4

micro suggests no packages.

-- no debconf information

Reply via email to