Dear Simon, I've addressed all your comments and pushed my changes. https://salsa.debian.org/debian/guile-colorized
just pasting the commit message here:
- Remove d/.gitignore for tag2upload
- Fix copyright attribution
- Add Build-Profiles: <!noguile> for binary package
- Replace override_dh_auto_clean
- Fix gbp.conf
Apart from these I have also filed an issue upstream like you asked:
https://gitlab.com/NalaGinrut/guile-colorized/-/work_items/12
They have responded with the following message:
> Thanks for mentioning this, I didn't realize this typo. It should be
GPLv3, I've fixed in src.
I have gone ahead and updated the copyright block to GPL-3.0+, added a comment explaining the change and linked to the upstream's response. Is that okay?
Thanks and Regards, Shriram Ravindranathan On 5/12/26 5:51 PM, Simon Josefsson wrote:
Thanks - I moved it to the debian namespace. I'm happy to sponsor upload, although some feedback: - Consider using gbp.conf dist=DEP14, sign-tags=True, and upstream-vcs-tag=v%(version%~%-)s - Consider simplifying override_dh_auto_clean by using execute_before_dh_auto_clean. - Consider adding a Build-Profiles: <!noguile> to the binary package. - I would drop debian/.gitignore for tag2upload compatibility. - Upstream copyright situation is unclear, please file a bug asking for clarification. Is the intent GPL-3+ (from LICENSE file) or LGPL-3+ (from the only real source code file ice-9/colorized.scm)? - Instead of faking copyright notices for authors, I would put those names in a comment. There is no real clear policy on this though, sometimes ftp-masters has asked to add copyright notices for people who are clearly authors but where upstream doesn't contain a copyright notice. I would use something like this: Files: ice-9/colorized.scm Copyright: 2013-2014 Free Software Foundation, Inc. License: LGPL-3.0+ Comment: Author: Mu Lei known as NalaGinrut <[email protected]> /Simon Shriram Ravindranathan <[email protected]> writes:Hi Simon, Thanks for offering to review and sponsor my package. I have packaged it and pushed my changes to https://salsa.debian.org/s20n/guile-colorized where I've also added you as the owner. Since upstream does not release tarballs and only tags the versions, I have gone with the git based workflow with upstreamvcs gitlab.com/NalaGinrut/guile-colorized As for the author's name in the copyright blocks, I have stuck with the name provided in the source header verbatim. I took the liberty to change the upstream contact to the email address they are using in the more recent commits (commits in upstream/latest after the current tag). I hope that is okay. Please have a look when you get time. Best Regards, Shriram Ravindranathan On 5/12/26 1:56 PM, Simon Josefsson wrote:Nice! I'm happy to review and sponsor this, but also happy if someone else beats me to it. /Simon Shriram Ravindranathan <[email protected]> writes:Package: wnpp Severity: wishlist Owner: Shriram Ravindranathan <[email protected]> X-Debbugs-Cc: [email protected], [email protected] * Package name : guile-colorized Version : 0.1 Upstream Contact: Mu Lei (NalaGinrut) <[email protected]> * URL : https://gitlab.com/NalaGinrut/guile-colorized * License : GPL-3 Programming Lang: Scheme Description : Colorized REPL for GNU Guile guile-colorized provides colorized, syntax-highlighted outputs for the Guile REPL. By default, Guile comes with an plain REPL which has an uncolored prompt and uncolored outputs. guile-colorized adds colors to the prompt as well as syntax highlighting to the outputs to improve readability. - This package is widely used by users of the Guile REPL. Infact, the often recommended quality-of-life improvements for the REPL are activiating guile-colorized and readline support and adding it to the ~/.guile file. For example, this Guile tutorial: - https://jeko.frama.io/en/install.html - I Intend to maintain it with the Debian Scheme team. I do require a sponsor for the upload though.
OpenPGP_0xFC7E951A7BEF0836.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
