Source: c-icap-modules Version: 1:0.5.7-1 Usertags: pidof-without-procps Dear maintainer(s) of c-icap-modules,
it appears that c-icap-modules uses `pidof` in its testsuite, or that at least one of its binary packages uses `pidof` at runtime. Historically, `pidof` was provided by the Essential package `sysvinit-tools`, making an explicit dependency unnecessary. However `pidof` will soon be moved to `procps` and will no longer be part of the Essential set. Please add an explicit dependency on `procps`: * via the `Depends:` field of all binary packages of c-icap-modules that use `pidof` at runtime; * via the `Build-Depends:` field of c-icap-modules, if `pidof` is used in tests run at build-time; * via the `Depends:` field of `debian/control/tests`, if `pidof` is used in autopkgtests. To prevent any disruption for users of c-icap-modules, please add this dependency now, before `pidof` is moved from `sysvinit-utils` to `procps`. Alternatively, you could remove all uses of `pidof`. It is believed that c-icap-modules uses `pidof` due to the following code snippets: ``` path: c-icap-modules_1:0.5.7-1/debian/tests/toolbox.sh # Let the service get time to start before reading pid file /bin/sleep 0.1 pidof /usr/bin/c-icap > /dev/null || die 'c-icap is not running' test -f /var/run/c-icap/c-icap.pid || error 'PidFile missing' test -p /var/run/c-icap/c-icap.ctl || error 'CommandsSocket missing' ``` Feel free to close this issue if this is a false positive (for example if this code is in an unreachable code path). Regards, -- Gioele Barabucci
