Source: bash-completion
Version: 1:2.16.0-8
Usertags: pidof-without-procps
Dear maintainer(s) of bash-completion,
it appears that bash-completion uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of bash-completion
that use `pidof` at runtime;
* via the `Build-Depends:` field of bash-completion, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of bash-completion, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that bash-completion uses `pidof` due to the following
code snippets:
```
path: bash-completion_1:2.16.0-8/test/t/test_pidof.py
class TestPidof:
# "p": Assume that our process name completion runs ps
@pytest.mark.complete("pidof p")
def test_1(self, completion):
assert completion
path: bash-completion_1:2.16.0-8/test/t/test_pidof.py
@pytest.mark.complete(
"pidof -", require_cmd=True, xfail="! pidof --help &>/dev/null"
)
def test_2(self, completion):
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
