Source: clonezilla
Version: 5.15.28-1
Usertags: pidof-without-procps
Dear maintainer(s) of clonezilla,
it appears that clonezilla uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of clonezilla
that use `pidof` at runtime;
* via the `Build-Depends:` field of clonezilla, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of clonezilla, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that clonezilla uses `pidof` due to the following
code snippets:
```
path: clonezilla_5.15.4-1/sbin/ocs-srv-live
dhcpd_pid="$(LC_ALL=C pidof dhcpd || LC_ALL=C pidof dhcpd3 || LC_ALL=C pidof
dnsmasq)"
tftpd_pid="$(LC_ALL=C pidof in.tftpd || LC_ALL=C pidof dnsmasq)"
unfsd_pid="$(LC_ALL=C pidof unfsd)"
nfsd_pid="$(LC_ALL=C pidof nfsd)"
if [ -z "$dhcpd_pid" -o -z "$tftpd_pid" ] || [ -z "$unfsd_pid" -a -z
"$nfsd_pid" ]; then
path: clonezilla_5.15.4-1/setup/files/ocs/ocs-run
*select_in_client*)
# For Ubuntu < 13.10, the plymouthd might be running even we force to
disable it in /etc/init/plymouth.conf. Therefore we force to stop it before
running clonezilla dialog menu. Otherwise the keyboard will have problem.
if [ -n "$(pidof plymouthd)" ]; then
/bin/plymouth quit
fi
path: clonezilla_5.15.4-1/sbin/ocs-prep-repo
modprobe nfs
fi
pid_rpcbind="$(LC_ALL=C pidof rpcbind)"
if [ -z "$pid_rpcbind" ]; then
echo "Service rpcbind is necesary for NFS client. Start it now..."
path: clonezilla_5.15.4-1/sbin/ocs-prep-repo
fi
# We assume nfs-common only runs rpc.statd (for NFS3), no rpc.lockd. This is
true for modern kernel (>=2.4).
pid_rpc_statd="$(LC_ALL=C pidof rpc.statd)"
if [ -z "$pid_rpc_statd" ]; then
if [ -e /etc/init.d/nfs-common ]; then
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
